Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-gen: migrate scalar functions (datetime) documentation 1/2 #13920

Merged

Conversation

Chen-Yuan-Lai
Copy link
Contributor

@Chen-Yuan-Lai Chen-Yuan-Lai commented Dec 27, 2024

Which issue does this PR close?

Part of #13671 .

Rationale for this change

What changes are included in this PR?

As discussed in #13671 , this PR will migrate the parts of builtin datetime functions documentation that currently support migration.

Are these changes tested?

Are there any user-facing changes?

@jonahgao
Copy link
Member

This PR has 1 failing CI check that needs to be fixed

@Chen-Yuan-Lai
Copy link
Contributor Author

@jonahgao I found similar CI check failures in other PRs - I'll fix them all together. Thanks for reviewing 🙏

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 28, 2024
Copy link
Contributor

@Omega359 Omega359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Chen-Yuan-Lai and @Omega359 🙏

@alamb alamb merged commit a203c2b into apache:main Dec 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants