Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-gen: migrate scalar functions (string) documentation 3/4 #13926

Merged

Conversation

Chen-Yuan-Lai
Copy link
Contributor

@Chen-Yuan-Lai Chen-Yuan-Lai commented Dec 27, 2024

Which issue does this PR close?

Closes #13671 .

Rationale for this change

What changes are included in this PR?

As discussed in #13671 , this PR will migrate the parts of builtin string functions documentation that currently support migration.

Are these changes tested?

Are there any user-facing changes?

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that the results of ./dev/update_function_docs.sh have not changed.
LGTM, Thanks @Chen-Yuan-Lai

@jonahgao jonahgao merged commit 618767e into apache:main Dec 28, 2024
28 checks passed
@jonahgao
Copy link
Member

I merged it, and maybe other related PRs can automatically run CI , which was previously blocked by “first-time contributor”.

Omega359 pushed a commit to Omega359/arrow-datafusion that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc-gen: Migrate builtin scalar functions from code based documentation to attribute based
2 participants