-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add enforcer rule for jdk version used in dependencies #251
base: main
Are you sure you want to change the base?
Conversation
<!-- Ensure no dependencies are using incompatible versions of java --> | ||
<enforceBytecodeVersion> | ||
<maxJdkVersion>${java.version}</maxJdkVersion> | ||
<ignoredScopes>test</ignoredScopes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how frequent such a usecase is but i'm tempted to put <strict>true</strict>
as well here. By default it's set to false and could lead to issues? Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try it out. It is better to be as "strict" as possible for now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causing lots of breakages: jackson, lombok, log4j all trigger the enforcer rule now
@the-other-tim-brown should we revive this PR? I used this idea on one of my projects, thanks for exploring these options. BTW, we can add more specific enforcements to fail the build if lets say they try to build with jdk8. Here are few rules that I'm using at
|
What is the purpose of the pull request
Prevents runtime issues where we depend on a dependency that requires a newer version of java to run.
Brief change log
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.