-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[590] Add Iceberg Glue Catalog Sync implementation #599
Open
kroushan-nit
wants to merge
2
commits into
apache:590-CatalogSync
Choose a base branch
from
kroushan-nit:590-IcebergGlueSync
base: 590-CatalogSync
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[590] Add Iceberg Glue Catalog Sync implementation #599
kroushan-nit
wants to merge
2
commits into
apache:590-CatalogSync
from
kroushan-nit:590-IcebergGlueSync
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroushan-nit
changed the title
590 iceberg glue sync
Add Iceberg Glue Catalog Sync implementation
Dec 12, 2024
kroushan-nit
commented
Dec 12, 2024
xtable-core/src/main/java/org/apache/xtable/reflection/ReflectionUtils.java
Show resolved
Hide resolved
kroushan-nit
commented
Dec 12, 2024
kroushan-nit
commented
Dec 12, 2024
xtable-aws/src/main/java/org/apache/xtable/glue/GlueCatalogConfig.java
Outdated
Show resolved
Hide resolved
kroushan-nit
commented
Dec 12, 2024
xtable-aws/src/main/java/org/apache/xtable/glue/GlueCatalogSyncClient.java
Outdated
Show resolved
Hide resolved
kroushan-nit
commented
Dec 12, 2024
xtable-aws/src/main/java/org/apache/xtable/glue/GlueSchemaExtractor.java
Outdated
Show resolved
Hide resolved
kroushan-nit
commented
Dec 12, 2024
xtable-aws/src/main/java/org/apache/xtable/glue/IcebergGlueCatalogSyncClient.java
Outdated
Show resolved
Hide resolved
kroushan-nit
commented
Dec 12, 2024
xtable-core/src/main/java/org/apache/xtable/exception/CatalogSyncException.java
Show resolved
Hide resolved
kroushan-nit
commented
Dec 13, 2024
xtable-core/src/main/java/org/apache/xtable/catalog/glue/GlueCatalogConfig.java
Show resolved
Hide resolved
kroushan-nit
commented
Dec 13, 2024
xtable-core/src/main/java/org/apache/xtable/catalog/glue/GlueCatalogConversionSource.java
Show resolved
Hide resolved
kroushan-nit
commented
Dec 13, 2024
xtable-core/src/main/java/org/apache/xtable/catalog/glue/GlueCatalogConversionSource.java
Show resolved
Hide resolved
kroushan-nit
commented
Dec 13, 2024
xtable-core/src/main/java/org/apache/xtable/catalog/glue/GlueCatalogConfig.java
Show resolved
Hide resolved
kroushan-nit
commented
Dec 13, 2024
xtable-core/src/main/java/org/apache/xtable/catalog/glue/GlueCatalogSyncClient.java
Outdated
Show resolved
Hide resolved
kroushan-nit
commented
Dec 13, 2024
xtable-core/src/main/java/org/apache/xtable/catalog/glue/IcebergGlueCatalogSyncOperations.java
Outdated
Show resolved
Hide resolved
kroushan-nit
commented
Dec 16, 2024
xtable-core/src/main/java/org/apache/xtable/catalog/TableFormatUtils.java
Outdated
Show resolved
Hide resolved
vinishjail97
force-pushed
the
590-CatalogSync
branch
3 times, most recently
from
December 19, 2024 22:12
a723014
to
ced6288
Compare
kroushan-nit
force-pushed
the
590-IcebergGlueSync
branch
from
December 21, 2024 06:38
77e54bd
to
d6ae25a
Compare
kroushan-nit
changed the title
Add Iceberg Glue Catalog Sync implementation
[590] Add Iceberg Glue Catalog Sync implementation
Dec 21, 2024
vinishjail97
force-pushed
the
590-CatalogSync
branch
from
December 24, 2024 01:35
6e09f5d
to
893b1a6
Compare
kroushan-nit
force-pushed
the
590-IcebergGlueSync
branch
from
December 26, 2024 08:21
da244b7
to
71ed9f0
Compare
vinishjail97
force-pushed
the
590-CatalogSync
branch
from
December 26, 2024 19:37
893b1a6
to
eefbdd2
Compare
kroushan-nit
force-pushed
the
590-IcebergGlueSync
branch
from
December 27, 2024 05:00
71ed9f0
to
b4d8cf8
Compare
kroushan-nit
force-pushed
the
590-IcebergGlueSync
branch
from
December 27, 2024 05:07
b4d8cf8
to
5daece8
Compare
@@ -138,12 +138,23 @@ | |||
<scope>provided</scope> | |||
</dependency> | |||
|
|||
<!-- AWS Glue dependencies --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to create a new module for the Glue related code. That will allow our users to only pull in the dependencies that they require.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
Add Glue catalog sync client implementation for Iceberg
Brief change log
Verify this pull request