chore: git mod - test fixes

app/client/cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts

@@ -42,10 +42,10 @@ describe(
         _.dataManager.dsValues[_.dataManager.defaultEnviorment].mockApiUrl,
         "GitSyncTest",
       );
-      _.gitSync.OpenGitSyncModal();
+      _.gitSync.OpenConnectModal();
       cy.get("body").type(`{${modifierKey}}{enter}`);
       cy.get("@postExecute").should("not.exist");
-      _.gitSync.CloseGitSyncModal();
+      _.gitSync.CloseConnectModal();
       cy.get("body").type(`{${modifierKey}}{enter}`);
       _.assertHelper.AssertNetworkStatus("@postExecute");
     });
@@ -60,7 +60,9 @@ describe(
         _.dataSources.CreatePlugIn("PostgreSQL");
         _.dataSources.FillPostgresDSForm();
         _.dataSources.SaveDSFromDialog(false);
-        _.agHelper.AssertElementVisibility(_.gitSync._branchButton);
+        _.agHelper.AssertElementVisibility(
+          _.gitSync.locators.quickActionsBranchBtn,
+        );
         cy.get("@gitRepoName").then((repName) => {
           repoName = repName;
         });
@@ -106,18 +108,20 @@ describe(
         _.agHelper.GetNClick(_.locators._appNavigationSettingsShowTitle);
         AppSidebar.navigate(AppSidebarButton.Editor);
         _.agHelper.GetNClick(_.locators._publishButton);
-        _.agHelper.WaitUntilEleAppear(_.gitSync._gitStatusChanges);
-        _.agHelper.GetNClick(_.gitSync._discardChanges);
-        _.agHelper.WaitUntilEleAppear(_.gitSync._discardCallout);
+        _.agHelper.WaitUntilEleAppear(_.gitSync.locators.status);
+        _.agHelper.GetNClick(_.gitSync.locators.opsDiscardBtn);
+        _.agHelper.WaitUntilEleAppear(
+          _.gitSync.locators.opsDiscardWarningCallout,
+        );
         _.agHelper.AssertContains(
           Cypress.env("MESSAGES").DISCARD_CHANGES_WARNING(),
           "exist",
-          _.gitSync._discardCallout,
+          _.gitSync.locators.opsDiscardWarningCallout,
         );
         _.agHelper.AssertContains(
           Cypress.env("MESSAGES").DISCARD_MESSAGE(),
           "exist",
-          _.gitSync._discardCallout,
+          _.gitSync.locators.opsDiscardWarningCallout,
         );
         _.agHelper.GetNClick(_.locators._dialogCloseButton);
       });
@@ -147,18 +151,18 @@ describe(
       _.gitSync.CreateGitBranch(tempBranch1, true);
       _.gitSync.CreateGitBranch(tempBranch2, true);
       _.gitSync.CreateGitBranch(tempBranch3, true);
-      _.agHelper.AssertElementExist(_.gitSync._bottomBarPull);
-      _.agHelper.GetNClick(_.gitSync._bottomBarMergeButton);
+      _.agHelper.AssertElementExist(_.gitSync.locators.quickActionsPullBtn);
+      _.agHelper.GetNClick(_.gitSync.locators.quickActionsMergeBtn);
       _.agHelper.AssertElementEnabledDisabled(
-        _.gitSync._mergeBranchDropdownDestination,
+        _.gitSync.locators.opsMergeBranchSelect,
         0,
         false,
       );
       _.agHelper.Sleep(6000); // adding wait for branch list to load
-      _.agHelper.GetNClick(_.gitSync._mergeBranchDropdownDestination);
+      _.agHelper.GetNClick(_.gitSync.locators.opsMergeBranchSelect);
       // to verify scroll works and clicks on last branch in list
-      _.agHelper.GetNClick(_.gitSync._dropdownmenu, 5);
-      _.gitSync.CloseGitSyncModal();
+      _.agHelper.GetNClick(".rc-select-item-option-content", 5);
+      _.gitSync.CloseConnectModal();
     });
 
     it("8. Bug 24206 : Open repository button is not functional in git sync modal", function () {

app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts

@@ -54,12 +54,16 @@ describe(
 
       // this logic will have to be removed after decimal issue with auto-commit is resolved
       assertHelper.AssertNetworkResponseData("gitStatus");
-      agHelper.AssertElementExist(gitSync._bottomBarCommit, 0, 30000);
-      agHelper.GetNClick(gitSync._bottomBarCommit);
-      agHelper.AssertElementVisibility(gitSync._gitSyncModal);
-      agHelper.GetNClick(gitSync._commitButton);
+      agHelper.AssertElementExist(
+        gitSync.locators.quickActionsCommitBtn,
+        0,
+        30000,
+      );
+      agHelper.GetNClick(gitSync.locators.quickActionsCommitBtn);
+      agHelper.AssertElementVisibility(gitSync.locators.opsModal);
+      agHelper.GetNClick(gitSync.locators.quickActionsCommitBtn);
       assertHelper.AssertNetworkStatus("@commit", 201);
-      gitSync.CloseGitSyncModal();
+      gitSync.CloseOpsModal();
     });
 
     it("1. Deploy the app & Validate CRUD pages - Mongo , MySql, Postgres pages", () => {

app/client/cypress/e2e/Regression/ClientSide/Git/GitAutocommit_spec.ts

@@ -56,7 +56,7 @@ describe(
           expect(
             interception?.response?.body?.data?.autoCommitResponse,
           ).to.equal("PUBLISHED");
-          agHelper.WaitUntilEleAppear(gitSync._autocommitStatusbar);
+          agHelper.WaitUntilEleAppear(gitSync.locators.autocommitLoader);
         });
         cy.wait("@gitAutocommitProgressApi").then((interceptions) => {
           expect(interceptions?.response?.statusCode).to.equal(200);

app/client/cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js

@@ -9,7 +9,6 @@ import {
   propPane,
 } from "../../../../../support/Objects/ObjectsCore";
 
-import gitSyncLocators from "../../../../../locators/gitSyncLocators";
 import EditorNavigation, {
   EntityType,
   PageLeftPane,
@@ -187,8 +186,8 @@ describe(
     it("9. On discard failure an error message should be show and user should be able to discard again", () => {
       cy.Createpage(page3);
 
-      agHelper.GetNClick(gitSyncLocators.bottomBarCommitButton);
-      agHelper.AssertElementVisibility(gitSyncLocators.discardChanges);
+      agHelper.GetNClick(gitSync.locators.quickActionsCommitBtn);
+      agHelper.AssertElementVisibility(gitSync.locators.opsDiscardBtn);
       cy.intercept("PUT", "/api/v1/git/discard/app/*", {
         body: {
           responseMeta: {
@@ -206,27 +205,27 @@ describe(
       });
 
       agHelper
-        .GetElement(gitSyncLocators.discardChanges)
+        .GetElement(gitSync.locators.opsDiscardBtn)
         .children()
         .should("have.text", "Discard & pull");
 
-      agHelper.GetNClick(gitSyncLocators.discardChanges);
+      agHelper.GetNClick(gitSync.locators.opsDiscardBtn);
       agHelper.AssertContains(
         Cypress.env("MESSAGES").DISCARD_CHANGES_WARNING(),
       );
       agHelper
-        .GetElement(gitSyncLocators.discardChanges)
+        .GetElement(gitSync.locators.opsDiscardBtn)
         .children()
         .should("have.text", "Are you sure?");
-      agHelper.GetNClick(gitSyncLocators.discardChanges);
+      agHelper.GetNClick(gitSync.locators.opsDiscardBtn);
       agHelper.AssertContains(
         Cypress.env("MESSAGES").DISCARDING_AND_PULLING_CHANGES(),
       );
       cy.contains(Cypress.env("MESSAGES").DISCARDING_AND_PULLING_CHANGES());
       agHelper.Sleep(2000);
 
       agHelper.AssertElementVisibility(".ads-v2-callout__children");
-      agHelper.AssertElementVisibility(gitSyncLocators.discardChanges);
+      agHelper.AssertElementVisibility(gitSync.locators.opsDiscardBtn);
     });
 
     after(() => {

app/client/cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js

@@ -1,4 +1,3 @@
-import gitSyncLocators from "../../../../../locators/gitSyncLocators";
 import homePageLocators from "../../../../../locators/HomePage";
 import reconnectDatasourceModal from "../../../../../locators/ReconnectLocators";
 const datasourceEditor = require("../../../../../locators/DatasourcesEditor.json");
@@ -85,7 +84,7 @@ describe(
           gitSync.CreateGitBranch(repoName);
         });
 
-        agHelper.AssertElementExist(gitSync._bottomBarPull);
+        agHelper.AssertElementExist(gitSync.locators.quickActionsPullBtn);
       });
     });
 
@@ -129,11 +128,11 @@ describe(
         cy.log(interception.response.body.data);
         cy.wait(1000);
       });
-      agHelper.AssertElementExist(gitSync._bottomBarPull);
+      agHelper.AssertElementExist(gitSync.locators.quickActionsPullBtn);
 
       cy.wait(3000); //for uncommited changes to appear if any!
       cy.get("body").then(($body) => {
-        if ($body.find(gitSyncLocators.gitPullCount).length > 0) {
+        if ($body.find(gitSync.locators.quickActionsCommitCount).length > 0) {
           gitSync.CommitAndPush();
         }
       });
@@ -179,12 +178,12 @@ describe(
       // deploy the app and validate data binding
       cy.wait(2000);
       cy.get(homePageLocators.publishButton).click();
-      agHelper.AssertElementExist(gitSync._bottomBarPull);
-      cy.get(gitSyncLocators.commitCommentInput).type("Initial Commit");
-      cy.get(gitSyncLocators.commitButton).click();
+      agHelper.AssertElementExist(gitSync.locators.quickActionsPullBtn);
+      cy.get(gitSync.locators.opsCommitInput).type("Initial Commit");
+      cy.get(gitSync.locators.opsCommitBtn).click();
       cy.intercept("POST", "api/v1/git/commit/app/*").as("commit");
-      agHelper.AssertElementExist(gitSync._bottomBarPull);
-      cy.get(gitSyncLocators.closeGitSyncModal).click();
+      agHelper.AssertElementExist(gitSync.locators.quickActionsPullBtn);
+      gitSync.CloseOpsModal();
       cy.wait(2000);
       gitSync.MergeToMaster();
       cy.wait(2000);
@@ -230,7 +229,7 @@ describe(
       cy.wait(3000);
       gitSync.CommitAndPush();
       cy.merge(newBranch);
-      cy.get(gitSyncLocators.closeGitSyncModal).click();
+      gitSync.CloseOpsModal();
       cy.wait(2000);
       cy.switchGitBranch(newBranch);
       cy.wait(4000);

app/client/cypress/e2e/Regression/ClientSide/Git/GitImport/ImportEmptyRepo_spec.js

@@ -1,5 +1,3 @@
-import homePage from "../../../../../locators/HomePage";
-import gitSyncLocators from "../../../../../locators/gitSyncLocators";
 import * as _ from "../../../../../support/Objects/ObjectsCore";
 
 describe(
@@ -44,7 +42,7 @@ describe(
           const message = interception.response.body.responseMeta.error.message;
           expect(status).to.be.gte(400);
           expect(message).to.contain(failureMessage);
-          cy.get(gitSyncLocators.closeGitSyncModal).click();
+          _.gitSync.CloseConnectModal();
         });
       });
     });

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js

@@ -1,5 +1,3 @@
-import gitSyncLocators from "../../../../../locators/gitSyncLocators";
-
 import { agHelper, gitSync } from "../../../../../support/Objects/ObjectsCore";
 import {
   PageLeftPane,
@@ -39,7 +37,7 @@ describe(
         agHelper.ValidateToastMessage(
           `Cannot delete checked out branch. Please check out other branch before deleting ${branchName}.`,
         );
-        cy.get(gitSyncLocators.closeBranchList).click({ force: true });
+        cy.get(gitSync.locators.branchCloseBtn).click({ force: true });
         // switch to master and delete new branch created
         cy.switchGitBranch("master");
         cy.wait(2000);
@@ -50,7 +48,7 @@ describe(
           "response.body.responseMeta.status",
           200,
         );
-        cy.get(gitSyncLocators.closeBranchList).click({ force: true });
+        cy.get(gitSync.locators.branchCloseBtn).click({ force: true });
         // verify remote branch is there for the deleted local branch
         cy.wait(2000);
         cy.switchGitBranch(`origin/${branchName}`);
@@ -79,7 +77,7 @@ describe(
         "response.body.responseMeta.status",
         200,
       );
-      cy.get(gitSyncLocators.closeBranchList).click({ force: true });
+      cy.get(gitSync.locators.branchCloseBtn).click({ force: true });
       cy.get(".t--draggable-checkboxwidget").should("be.visible");
     });
 
@@ -103,25 +101,25 @@ describe(
         200,
       );
       cy.get(".--widget-chartwidget").should("not.exist");
-      cy.get(gitSyncLocators.closeBranchList).click({ force: true });
+      cy.get(gitSync.locators.branchCloseBtn).click({ force: true });
     });
 
     it("4. Verify Default branch deletion not allowed ", () => {
       agHelper.Sleep(2000); //for toasts to appear then wait for disappear
       agHelper.WaitUntilAllToastsDisappear();
       DeleteBranchFromUI(0);
-      cy.get(gitSyncLocators.closeBranchList).click({ force: true });
+      cy.get(gitSync.locators.branchCloseBtn).click({ force: true });
       agHelper.ValidateToastMessage("Cannot delete default branch: master");
     });
 
     function DeleteBranchFromUI(index = 1) {
-      cy.get(gitSyncLocators.branchButton).click();
-      cy.get(gitSyncLocators.branchListItem)
+      cy.get(gitSync.locators.quickActionsBranchBtn).click();
+      cy.get(gitSync.locators.branchItem)
         .eq(index)
         .trigger("mouseenter")
         .wait(1000);
-      cy.get(gitSyncLocators.gitBranchContextMenu).click({ force: true });
-      cy.xpath("//div[@role='menu']//span[text()='Delete']")
+      cy.get(gitSync.locators.branchItemMenuBtn).click({ force: true });
+      cy.get(gitSync.locators.branchItemMenuDeleteBtn)
         .should("be.visible")
         .click({ force: true });
     }

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js

@@ -1,4 +1,3 @@
-import gitSyncLocators from "../../../../../locators/gitSyncLocators";
 import homePage from "../../../../../locators/HomePage";
 import * as _ from "../../../../../support/Objects/ObjectsCore";
 
@@ -36,19 +35,19 @@ describe(
     it("1. Validate commit comment inputbox and last deployed preview", function () {
       // last deployed preview
       // The deploy preview Link should be displayed only after the first commit done
-      cy.get(gitSyncLocators.bottomBarCommitButton).click();
+      cy.get(_.gitSync.locators.quickActionsCommitBtn).click();
 
-      cy.get(gitSyncLocators.commitCommentInput).should("be.disabled");
-      cy.get(gitSyncLocators.commitButton).should("be.disabled");
-      cy.get(gitSyncLocators.closeGitSyncModal).click();
+      cy.get(_.gitSync.locators.opsCommitInput).should("be.disabled");
+      cy.get(_.gitSync.locators.opsCommitBtn).should("be.disabled");
+      _.gitSync.CloseOpsModal();
     });
 
     it("2. Post connection app name deploy menu", function () {
       // deploy
       _.agHelper.GetNClick(_.locators._publishButton);
 
-      cy.get(gitSyncLocators.gitSyncModal);
-      cy.get(gitSyncLocators.gitSyncModalDeployTab)
+      cy.get(_.gitSync.locators.opsModal);
+      cy.get(_.gitSync.locators.opsModalTabDeploy)
         .should("have.attr", "aria-selected", "true")
         .and("not.be.empty");
       cy.window().then((window) => {
@@ -58,7 +57,7 @@ describe(
         });
       });
 
-      cy.get(gitSyncLocators.closeGitSyncModal).click();
+      _.gitSync.CloseOpsModal();
 
       // current deployed version
       _.agHelper.GetNClick(homePage.deployPopupOptionTrigger);