Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail queries using APPROX_NEAR but not using vector index #21528

Open
wants to merge 294 commits into
base: devel
Choose a base branch
from
Open

Fail queries using APPROX_NEAR but not using vector index #21528

wants to merge 294 commits into from

Conversation

jbajic
Copy link
Contributor

@jbajic jbajic commented Dec 19, 2024 •
edited
Loading

Scope & Purpose

Fail a query with an error when APPROX_NEAR is used but vector index was not applied. It might not be expected from the user perspective to just fall back onto L2_DISTANCE or COSINE_SIMILARITY

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

jbajic added 30 commits August 16, 2024 16:17
@jbajic
Add formation of rocksdb value for faiss
6e70205
@jbajic
Split vector definition into user defined and trained
8b0c7a5
@jbajic
Add faiss glue for inserting
28b13a0
@jbajic
Add preperation for index creation
f3192c7
@jbajic
Add support for float in inspector
8830130
@jbajic
Clean up key and value for vector index
b8636a9
@jbajic
Temp
bcb7f2f
@jbajic
Resolve memory leak
d18e09b
@jbajic
Make search work
6133788
@jbajic
Remove logs
8dae955
@jbajic
Remove faiss iter and list from headers
2dc11a0
@jbajic
Add approx distance function
7ae709a
@jbajic
Merge branch 'devel' into feature/vector-index
7eb08f3
@jbajic
Add supportSortCondition
29251fe
@jbajic
Add OptimizerRule for introductingVectorIndex
63fbeef
@jbajic
Fix byte string in multidim index
ee94d14
@jbajic
Add rule with other rules
80b4919
@jbajic
Update CMake
b7333ee
@jbajic
Remove vector index specialization
0d6a182
@jbajic
Remove unused include
f73c597
@jbajic
Add additional checks into rule
60143cc
@jbajic
Small changes
21ce11b
@jbajic
Revert byte string changes
632542c
@jbajic
Rename prepareIndex2
136e3bb
@jbajic
Remove uneeded files
089c635
@jbajic
Change quantitizer to support multiple indexes
4ae94c0
@jbajic
Reorder checks in rule
a1ae64e
@jbajic
Fix training data size
69f8803
@jbajic
Fix byte string
f10e9e1
@jbajic
Add faiss submodule
282e8ac
@jbajic jbajic self-assigned this Dec 19, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 19, 2024
@jbajic jbajic requested a review from goedderz December 19, 2024 07:46
@jbajic jbajic added the 3 AQL Query language related label Dec 19, 2024
@jbajic jbajic marked this pull request as ready for review December 19, 2024 13:34
Base automatically changed from feature/vector-index-nprobe to devel December 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goedderz goedderz Awaiting requested review from goedderz

At least 1 approving review is required to merge this pull request.

Assignees

@jbajic jbajic

Labels
3 AQL Query language related cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbajic @maierlars @KVS85 @goedderz