Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A library for interfacing with the MOTY-mini temperature sensor. #5669

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

wwhai
Copy link
Contributor

@wwhai wwhai commented Dec 28, 2024

A library for interfacing with the MOTY-mini temperature sensor.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 28, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/wwhai/MOTY-Mini-Temperature-Sensor.git

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @wwhai
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wwhai. Thanks for your interest in contributing to the Arduino Library Manager index.

I see the bot reported a problem with your submission that will block its acceptance:

A problem was found with your submission https://github.com/wwhai/MOTY-Mini-Temperature-Sensor.git

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Create a new release or tag in the library repository.
  2. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Dec 28, 2024
@wwhai
Copy link
Contributor Author

wwhai commented Dec 30, 2024

A library for interfacing with the MOTY-mini temperature sensor. @ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Dec 30, 2024
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/wwhai/MOTY-Mini-Temperature-Sensor.git:

Linting library in MOTY-Mini-Temperature-Sensor
INFO: No header file found matching library name (MOTY-Mini_Temperature_Sensor.h). Best practices are for primary header
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name MOTY-Mini Temperature Sensor contains spaces. Although supported, best practices is to 
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in MOTY-Mini-Temperature-Sensor/examples/BasicExample
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: BasicExample.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file           
         (Rule SS001)                                                                                          

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 December 30, 2024 07:27
Copy link
Contributor

Hi @wwhai
A problem was found with your pull request:

ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.

Please resolve this error. The checks will automatically run again once that is done.

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot added topic: invalid Request could not be processed and removed topic: submission Add library to the list labels Dec 30, 2024
@wwhai
Copy link
Contributor Author

wwhai commented Dec 30, 2024

resolved conflict. @ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Hi @wwhai
A problem was found with your pull request:

ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.

Please resolve this error. The checks will automatically run again once that is done.

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

A library for interfacing with the MOTY-mini temperature sensor.
@github-actions github-actions bot removed the request for review from per1234 December 30, 2024 23:32
@github-actions github-actions bot added topic: submission Add library to the list and removed topic: invalid Request could not be processed labels Dec 30, 2024
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/wwhai/MOTY-Mini-Temperature-Sensor.git:

Linting library in MOTY-Mini-Temperature-Sensor
INFO: No header file found matching library name (MOTY-Mini_Temperature_Sensor.h). Best practices are for primary header
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name MOTY-Mini Temperature Sensor contains spaces. Although supported, best practices is to 
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in MOTY-Mini-Temperature-Sensor/examples/BasicExample
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: BasicExample.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file           
         (Rule SS001)                                                                                          

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit 10837c6 into arduino:main Dec 30, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/hootrhino/MOTY-Mini-Temperature-Sensor/

github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
@per1234 per1234 self-assigned this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants