Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argocd-image-updater): Add new env to respect log level setting #3006

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wd
Copy link
Contributor

@wd wd commented Nov 1, 2024

This is a follow-up PR for argoproj-labs/argocd-image-updater#904; that PR resolved the logs generated by the code in argo-image-updater repo. This PR aims to resolve the logs generated by https://github.com/argoproj/gitops-engine/blob/master/pkg/utils/tracing/logging.go#L43 as I mentioned in the description of that PR.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@yu-croco
Copy link
Collaborator

yu-croco commented Nov 1, 2024

Hi @wd , thank you for your PR.
argoproj-labs/argocd-image-updater#904 is merged into master but not released as a specific version, so we should wait for the release.
Also since argo-helm follows upstream's manifests, can you please make PR in upstream?
Ref: https://github.com/argoproj-labs/argocd-image-updater/tree/master/manifests

@yu-croco yu-croco added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Nov 1, 2024
@wd
Copy link
Contributor Author

wd commented Nov 1, 2024

ah, I used the helm chart myself. I don't realize they have the manifest. I'll create a PR for that manifest as well. thank you.

@wd
Copy link
Contributor Author

wd commented Nov 4, 2024

Created the PR argoproj-labs/argocd-image-updater#913

update: the PR merged.

@wd
Copy link
Contributor Author

wd commented Nov 7, 2024

hi @yu-croco I just realized that this PR doesn't depend on argoproj-labs/argocd-image-updater#904, it is the same change as PR argoproj-labs/argocd-image-updater#913.
I think it should be safe to merge this PR, what do you think?

@yu-croco
Copy link
Collaborator

yu-croco commented Nov 7, 2024

@wd
The point is that we follow upstream's manifests.
argoproj-labs/argocd-image-updater#913 is merged into master but not released as specific version, so we wait for new version of argocd-image-updater. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argocd-image-updater awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants