Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): Fix readiness and liveness probes #3074

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mstypinski
Copy link

@mstypinski mstypinski commented Dec 9, 2024

Fix for swapped readiness and liveness probes

Liveness probes should return 200 as soon as pod is live in K8S. Readiness is used to determine if the pod is capable of handling more traffic.

More info: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@yu-croco
Copy link
Collaborator

Hi @mstypinski , thank you for your PR. We follow upstream manifest. If you think it's an issue, please open an issue in upstream as well.
https://github.com/argoproj/argo-cd/tree/master/manifests/base

We will follow as soon as upstream reflects and release new version.

@mkilchhofer mkilchhofer added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Dec 24, 2024
@mkilchhofer mkilchhofer marked this pull request as draft December 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants