Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified in a project page context vs full documentation. #106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

apj68
Copy link

@apj68 apj68 commented Mar 4, 2021

  • Removed TOC
  • Changed Usage to Quick Start to avoid conflict with full doc site
  • Remove documentation of doclet-options
  • Removed Ant sample
  • Added link to documentation

- Removed TOC
- Changed Usage to Quick Start to avoid conflict with full doc site
- Remove documentation of doclet-options
- Removed Ant sample
- Added link to documentation
@abelsromero
Copy link
Member

For other repos we remove most content tand left the minimal to point to the official docs. That way we don't need to maintein duplicated content twice. Also users get used to go to the docs site, and get the same experience for all projects (at least, those published).

PS: I think we should also review the https://github.com/asciidoctor/asciidoctorj README if the goal is to reduce READMES

@apj68
Copy link
Author

apj68 commented Mar 5, 2021

@abelsromero , do you think the pull request needs more to come out of the README? I tried to trim it back to keep it simple but leave enough to give an idea of how it was used. I see that the other examples you provided are a bit more spartan, I can take more out if needed.

@abelsromero
Copy link
Member

abelsromero commented Mar 5, 2021

do you think the pull request needs more to come out of the README?

It's more of an open questions to discuss, but I think we could trim more, for example I'd remove the "Resources and help".
Regardless, keep in mind I am not the repo ower, just trying to offer a transversal view aligned with other projects in the family.

@apj68
Copy link
Author

apj68 commented Mar 5, 2021

Let me take another crack, I agree the resources can go into the main documentation. The two examples you provided are definitely brief.

Andy Jewell added 2 commits March 5, 2021 14:36
- Removed TOC
- Changed Usage to Quick Start to avoid conflict with full doc site
- Remove documentation of doclet-options
- Removed Ant sample
- Added link to documentation

Additional minimization.

- Removed Resource and Help section (which is in main documentation)
- Removed TOC
- Changed Usage to Quick Start to avoid conflict with full doc site
- Remove documentation of doclet-options
- Removed Ant sample
- Added link to documentation

Additional minimization.

- Removed Resource and Help section (which is in main documentation)
@apj68
Copy link
Author

apj68 commented Mar 5, 2021

Ok, I removed the help section. I feel like the Quick Start is not useful without the samples so I left them in.

Also, I'm new at this and tried to squash the commits but I seemed to be going in a circle. I'd squash then I'd have a conflict, resolve the conflict, new commit, squash, new commit... etc!

@abelsromero
Copy link
Member

The only thing I'd would do is adding a link to the docs to the top.

Also, I'm new at this and tried to squash the commits but I seemed to be going in a circle. I'd squash then I'd have a conflict, resolve the conflict, new commit, squash, new commit... etc!

If you want to add changes to the last commit without creating a new commit, use git add WHAT_IS_NEEDED, then git commit --amend --no-edit. You will still need to force-push but avoid the hasle of squashing over and over.

@johncarl81 wdyt about this?

Andy Jewell added 2 commits March 12, 2021 09:22
- Removed TOC
- Changed Usage to Quick Start to avoid conflict with full doc site
- Remove documentation of doclet-options
- Removed Ant sample
- Added link to documentation

Additional minimization.

- Removed Resource and Help section (which is in main documentation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants