pep585 import aliases #983
Conversation
Signed-off-by: Stephen Finucane <[email protected]>
State.as_import probably has uses elsewhere, but this is sufficient to start with. We need to update some of the pep604 feature tests to ensure we actually do the import. Signed-off-by: Stephen Finucane <[email protected]>
| @@ -36,7 +36,7 @@ def visit_Attribute( | |||
| if ( | |||
| _should_rewrite(state) and | |||
| isinstance(node.value, ast.Name) and | |||
| node.value.id == 'typing' and | |||
| state.as_imports.get(node.value.id) == 'typing' and | |||
There was a problem hiding this comment.
Note that this breaks cases like we see in typing_pep604_test.py below, where we use typing without first importing it. I think that's okay since that code is already broken in real-life, but if we wanted to avoid making those changes we could trivially change this to:
| state.as_imports.get(node.value.id) == 'typing' and | |
| state.as_imports.get(node.value.id, node.value.id) == 'typing' and |
|
aliases present all sorts of problems and so they are intentionally not supported. |
I did my due diligence and couldn't find anything in the code or existing issues to suggest this. Additionally, I see support for aliased objects in multiple plugins. If there's a serious issue I've missed here than a little more context would have been a good learning experience for both me and anyone else that stumbles upon this issue. But fine 🤷 As always, been a pleasure interacting with you, Anthony 🙄 |
|
the only plug-in with support is the imports one because the result is unambiguous |
Track aliases so that pep585 rewriting works with e.g.