-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Alipay certificate signing and openid. #968
Open
BuknSS
wants to merge
2
commits into
aspnet-contrib:dev
Choose a base branch
from
BuknSS:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−2
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
src/AspNet.Security.OAuth.Alipay/AlipayCertificationUtils.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0) | ||
* See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers | ||
* for more information concerning the license and the contributors participating to this project. | ||
*/ | ||
|
||
using System.Numerics; | ||
using System.Security.Cryptography; | ||
using System.Security.Cryptography.X509Certificates; | ||
using System.Text; | ||
|
||
namespace AspNet.Security.OAuth.Alipay; | ||
|
||
/// <summary> | ||
/// This class of code refers to the Alipay official SDK code. | ||
/// See https://github.com/alipay/alipay-sdk-net-all/blob/1b7b73909954b107bddb6476dec68aafcc3f16e9/v2/AlipaySDKNet.Standard/Util/AntCertificationUtil.cs | ||
/// See https://opendocs.alipay.com/common/056zub?pathHash=91c49771 | ||
/// </summary> | ||
internal static class AlipayCertificationUtils | ||
{ | ||
internal static string GetCertSN([NotNull] string certFilePath) | ||
{ | ||
using var cert = X509Certificate.CreateFromCertFile(certFilePath); | ||
return GetCertSN(cert); | ||
} | ||
|
||
internal static string GetCertSN([NotNull] X509Certificate cert) | ||
{ | ||
var issuerDN = cert.Issuer.Replace(", ", ",", StringComparison.InvariantCulture); | ||
var input = issuerDN + new BigInteger(cert.GetSerialNumber()); | ||
#pragma warning disable CA5351 // Do Not Use Broken Cryptographic Algorithms | ||
var certSN = Convert.ToHexString(MD5.HashData(Encoding.UTF8.GetBytes(input))).ToLowerInvariant(); | ||
#pragma warning restore CA5351 // Do Not Use Broken Cryptographic Algorithms | ||
return certSN; | ||
} | ||
|
||
internal static string GetRootCertSN([NotNull] string rootCertPath, [NotNull] string signType = "RSA2") | ||
{ | ||
var certSNs = new List<string>(); | ||
var certCollection = new X509Certificate2Collection(); | ||
certCollection.ImportFromPemFile(rootCertPath); | ||
|
||
foreach (var cert in certCollection) | ||
{ | ||
if ((signType.StartsWith("RSA", StringComparison.Ordinal) && cert.SignatureAlgorithm.Value?.StartsWith("1.2.840.113549.1.1", StringComparison.Ordinal) == true) || | ||
(signType.Equals("SM2", StringComparison.Ordinal) && cert.SignatureAlgorithm.Value?.StartsWith("1.2.156.10197.1.501", StringComparison.Ordinal) == true)) | ||
{ | ||
certSNs.Add(GetCertSN(cert)); | ||
} | ||
} | ||
|
||
var rootCertSN = string.Join('_', certSNs); | ||
return rootCertSN; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't assume that certificates are on the file system - they could (should?) be stored in a secure location, such as the Windows Certificate Manager, or loaded from a remote source such as Azure Key Vault. Take a look at the Apple provider for examples on handling such scenarios.
This example might also help: configuring Sign in With Apple