fix: force 2 version of packageLock in the package-lock.json #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
smoya
approved these changes
Jan 17, 2022
Dockerfile
Outdated
| # install dependencies | ||
| RUN npm ci | ||
| # switch to the `npm ci` when https://github.com/asyncapi/.github/issues/123 issue will be resolved |
There was a problem hiding this comment.
It is better to remove the lock imho and recreate it here. Remember we found some issues with missing dependencies when using old nom versions (babel dep missing).
There was a problem hiding this comment.
I mean. Not ideal and should be eventually reverted, but better to recreate the lock with the right npm version than older.
|
🎉 This PR is included in version 0.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npm installnot bynpm cirelease) thepackage*files frombuildimageRelated issue(s)
Partially fixes asyncapi/.github#123