Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the length filter to truncate logs in the middle instead of truncating the end.
The beginning and end of a log file are usually the most interesting parts, as the beginning contains important version information used to detect the software and the end contains the error message of a crash.
The implementation was needed in both PHP and JS because this should work both for people using the API and the website (which already applied the old filter client side to prevent issues with upload limits).
Both implementations insert the same message at the center of the log:
I also changed the order of the length and lines filter to make sure that logs which reach both limits have their lines removed first.