Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Discogs Memory Error due to large albums #5550

Closed
wants to merge 6 commits into from

Conversation

arsaboo
Copy link
Contributor

@arsaboo arsaboo commented Dec 17, 2024

Description

Fixes #5207

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@snejus
Copy link
Member

snejus commented Dec 26, 2024

Hi @arsaboo, I've actually looked at this earlier and wanted to fix this issue for once and all.

I looked into the algorithm that beets uses for matching and I replaced it with one that is faster and uses less resources. This means beets should be able to handle candidates of any size. Let me find this work and submit a PR, then you could potentially test it?

@snejus
Copy link
Member

snejus commented Dec 27, 2024

@arsaboo see here: #5564

@arsaboo
Copy link
Contributor Author

arsaboo commented Dec 27, 2024

@snejus that's awesome. Closing this PR in favor of the other one.

@arsaboo arsaboo closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemoryError during import
2 participants