Add optional acorn options. #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2017
|
Does it need more work? |
ahdinosaur
reviewed
Mar 28, 2017
| @@ -33,6 +33,7 @@ function Deps (opts) { | |||
| }); | |||
| }; | |||
| this.cache = opts.cache; | |||
| this.acorn = {parse: {acorn: opts.acorn}}; | |||
There was a problem hiding this comment.
hey @jvanveen, thanks for the contribution! is acorn the best name for this option? and why is it nested in parse? your answer is as good as any, so just wondering your thoughts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of multiple pull-requests, so acorn options can flow like:
module-deps -> detective
Also see:
browserify/detective#69