Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .npmignore to make the published module smaller and work around a bug in Flow #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dumbmatter
Copy link

This will make everyone's life slightly better by making the module distributed through npm a bit smaller.

And it will save users of Flow some grief, because of facebook/flow#5898.

@anfedorov
Copy link

anfedorov commented May 23, 2018

looks good & would have appreciated not having to manually fix the flow error. eta?

@goto-bus-stop
Copy link
Member

Is this fixed in flow since facebook/flow@f942d96?

Shipping tests and examples with packages is handy if users are working offline or if they need to debug something.

@daniellizik
Copy link

daniellizik commented Feb 26, 2020

@goto-bus-stop [email protected] is still identifying this as an error for me

The main problem is, I have no idea why putting

[ignore]
node_modules

in my .flowconfig still reads all package.json files in node_modules...have you found another workaround?

@serhalp serhalp mentioned this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants