Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_iwasm_release.yml: Add shared lib build #3975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

midokura-xavi92
Copy link
Contributor

So far, no workflows would attempt to build the shared version of the iwasm library (namely, vmlib).

Note that, as opposed to GC_EH_BUILD_OPTIONS and DEFAULT_BUILD_OPTIONS, the actual default options defined by the build system are assumed, for the sake of simplicity and avoiding repeated code.

So far, no workflows would attempt to build the shared version of the
iwasm library (namely, vmlib).

Note that, as opposed to GC_EH_BUILD_OPTIONS and DEFAULT_BUILD_OPTIONS,
the actual default options defined by the build system are assumed, for
the sake of simplicity and avoiding repeated code.
@lum1n0us
Copy link
Collaborator

Are we planning to include a shared library in the final set of release binaries, or are we going to test the compilation of a shared library with each PR? If it's the former, then modifying build_iwasm_release.yml makes sense. However, if it's the latter, you might want to make changes to .github/workflows/compilation_on_* instead.

@midokura-xavi92
Copy link
Contributor Author

Are we planning to include a shared library in the final set of release binaries, or are we going to test the compilation of a shared library with each PR? If it's the former, then modifying build_iwasm_release.yml makes sense. However, if it's the latter, you might want to make changes to .github/workflows/compilation_on_* instead.

I do not decide which artifacts should be built for release, so I assume the latter only for now. I will then update the PR to only modify _.github/workflows/compilation_on__*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants