Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release builds, add aarch64-musl #9885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexcrichton
Copy link
Member

This commit refactors the way release builds are done in CI in terms of configuration and then additionally adds aarch64-musl release artifacts as requested in #9875. The refactoring here is done to reduce the number of locations to understand release builds. Notably the binary-compatible-builds action was removed in favor of direct environment configuration in conjunction with docker images used to build. The aarch64-musl build itself happens in a container provided by the cross project to ensure that the right toolchain is configured.

Closes #9875

This commit refactors the way release builds are done in CI in terms of
configuration and then additionally adds aarch64-musl release artifacts
as requested in bytecodealliance#9875. The refactoring here is done to reduce the number
of locations to understand release builds. Notably the
`binary-compatible-builds` action was removed in favor of direct
environment configuration in conjunction with docker images used to
build. The `aarch64-musl` build itself happens in a container provided
by the `cross` project to ensure that the right toolchain is configured.

Closes bytecodealliance#9875

prtest:full
@alexcrichton
Copy link
Member Author

@whitequark from this CI page if you scroll to the bottom and find bins-aarch64-musl (here's a direct link, not sure if that'll work) can you test that out? Mostly just make sure ./wasmtime --help does something and maybe poke at the commands a bit. If that works I think this is probably good to go to eventually get integrated into wasmtime-py

@whitequark
Copy link
Contributor

OK so here is what I get if I run wasmtime in alpine edge on aarch64:
Screenshot_20241220_210142

@whitequark
Copy link
Contributor

I think this might be Alpine-specific, for some reason libgcc isn't installed by default? Anyway, after I fixed that, it ran and executed a real Wasm application (nextpnr).

@alexcrichton
Copy link
Member Author

Ok perfect, thanks! I still don't know how to best manage libgcc_s on musl but it's at least no worse-off than the x64 target which I believe has the same behavior.

@alexcrichton alexcrichton marked this pull request as ready for review December 20, 2024 21:15
@alexcrichton alexcrichton requested a review from a team as a code owner December 20, 2024 21:15
@alexcrichton alexcrichton requested review from dicej and removed request for a team December 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing musl aarch64 build products
3 participants