pulley: Implement 16x8 arithmetics #9904
Merged
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "pulley"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Dec 27, 2024
pulley/src/interp.rs
Outdated
| let b = self.state[operands.src2].get_u16x8(); | ||
| for (a, b) in a.iter_mut().zip(&b) { | ||
| // rounding average | ||
| *a = (*a & *b) + ((*a ^ *b) >> 1) + ((*a ^ *b) & 1); |
There was a problem hiding this comment.
Could this perhaps be written as *a = (u32::from(a) + u32::from(b) + 1) / 2? Basically the more classical version of an average which explicitly takes advantage of wider-precision arithmetic to avoid overflow issues.
There was a problem hiding this comment.
instantly convinced :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #9783