tetragon: factor generic maps #3257
Open
+576
−855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several maps used in all generic sensors, moving them into single generic_maps.h header. Signed-off-by: Jiri Olsa <[email protected]>
Using process_call_heap in generic functions directly, so we don't need to pass it as argument. Passing map pointer through argument might end up storing and loading it to/from heap which makes it scalar value and breaks verifier. Signed-off-by: Jiri Olsa <[email protected]>
Using config_map in generic functions directly, so we don't need to pass it as argument. Passing map pointer through argument might end up storing and loading it to/from heap which makes it scalar value and breaks verifier. Signed-off-by: Jiri Olsa <[email protected]>
Using data_heap in generic functions directly, so we don't need to pass it as argument. Passing map pointer through argument might end up storing and loading it to/from heap which makes it scalar value and breaks verifier. Signed-off-by: Jiri Olsa <[email protected]>
Moving generic_output to generic functions and change it to use process_call_heap in generic functions directly, so we don't need to pass it as argument. Passing map pointer through argument might end up storing and loading it to/from heap which makes it scalar value and breaks verifier. Signed-off-by: Jiri Olsa <[email protected]>
Moving generic_actions to generic functions, so we can use generic maps in it directly in following changes. Signed-off-by: Jiri Olsa <[email protected]>
Switching generic_actions to use maps directly. Passing map pointer through argument might end up storing and loading it to/from heap which makes it scalar value and breaks verifier. Keeping tail call map, because it's convenient in following changes. Signed-off-by: Jiri Olsa <[email protected]>
Adding generic_retkprobe function (from generic_retkprobe_event) and change it to use process_call_heap in generic functions directly, so we don't need to pass it as argument. Passing map pointer through argument might end up storing and loading it to/from heap which makes it scalar value and breaks verifier. Signed-off-by: Jiri Olsa <[email protected]>
Switching generic_start_process_filter to use maps directly and drop struct generic_maps. Keeping tail call map, because it's convenient in following changes. Signed-off-by: Jiri Olsa <[email protected]>
Moving generic_process_filter to generic functions and changing it to use maps directly. Passing map pointer through argument might end up storing and loading it to/from heap which makes it scalar value and breaks verifier. Signed-off-by: Jiri Olsa <[email protected]>
Moving generic_actions to generic functions, so we can use generic maps in it directly in following changes. Signed-off-by: Jiri Olsa <[email protected]>
Switching generic_start_process_filter to use maps directly and drop struct generic_maps. Keeping tail call map, because it's convenient in following changes. And rename it to generic_filter_arg. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
added
the
release-note/minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move generic maps in one place and use them statically in generic sensor code (not passed through argument or structure). This makes a difference in more complex kprobe session code that's coming in shortly.