Maintain DATAGRAM sent/received statistics #1827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
force-pushed
the
pr_dgram_stats
branch
from
6b95509 to
1ff54a0
Compare
LPardue
reviewed
Nov 25, 2024
Comment on lines
+1412
to
+1415
| dgram_sent_count: usize, | ||
|
|
||
| /// Total number of received DATAGRAM frames. | ||
| dgram_recv_count: usize, |
There was a problem hiding this comment.
FWIW, in theory its possible for a minimally encoded length-prefixed DATAGRAM to take about 2 bytes and therefore a single packet to contain a lot of them. For a standard MTU, this would be like 600-700 but larger MTUs are possible. Therefore, there's a risk that the limit here could be breached orders of magnitude before the QUIC connection hit its packet count limit.
Not sure if that warrants a saturating_add on the counting but wanted to flag before I forgot.
There was a problem hiding this comment.
Good point. I changed += 1 to saturating_add(1) and rebased the commit on top of master.
hendrikcech
force-pushed
the
pr_dgram_stats
branch
3 times, most recently
from
bd24bc9 to
6b56e30
Compare
hendrikcech
force-pushed
the
pr_dgram_stats
branch
from
6b56e30 to
b77ccc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the number of sent and received DATAGRAM frames on the connection-level and on individual paths. It provides more visibility into what has been transferred over the connection. Currently only the number of sent and received packets is tracked.