Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate useSyncProviders to TS Query V5 #3573

Merged
merged 5 commits into from
Dec 23, 2024
Merged

chore: Migrate useSyncProviders to TS Query V5 #3573

merged 5 commits into from
Dec 23, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useSyncProviders to the TS Query queryOptions version SyncProvidersQueryOpts

Ticket: codecov/engineering-team#2962

Notable Changes

  • Migrate useSyncProviders to SyncProvidersQueryOpts
  • Update usage in SyncProviderPage
  • Update tests

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 132 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 66 bytes (0.0%) ⬆️
gazebo-production-system-esm 6.05MB 66 bytes (0.0%) ⬆️

@codecov-staging
Copy link

codecov-staging bot commented Dec 12, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 132 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.05MB 66 bytes (0.0%) ⬆️
gazebo-staging-system 6.0MB 66 bytes (0.0%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (7200eea) to head (537f7de).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3573   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14563    14563           
  Branches     4151     4157    +6     
=======================================
  Hits        14418    14418           
  Misses        138      138           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/SyncProviderPage/SyncProviderPage.tsx 100.00% <100.00%> (ø)
src/services/config/SyncProvidersQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <100.00%> (ø)
Services 99.36% <100.00%> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7200eea...537f7de. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3573   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14563    14563           
  Branches     4158     4157    -1     
=======================================
  Hits        14418    14418           
  Misses        138      138           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/SyncProviderPage/SyncProviderPage.tsx 100.00% <100.00%> (ø)
src/services/config/SyncProvidersQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <100.00%> (ø)
Services 99.36% <100.00%> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7200eea...537f7de. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (7200eea) to head (537f7de).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3573   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14563    14563           
  Branches     4158     4157    -1     
=======================================
  Hits        14418    14418           
  Misses        138      138           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/SyncProviderPage/SyncProviderPage.tsx 100.00% <100.00%> (ø)
src/services/config/SyncProvidersQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <100.00%> (ø)
Services 99.36% <100.00%> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7200eea...537f7de. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Dec 12, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
acc32be Thu, 12 Dec 2024 13:11:13 GMT Expired Expired
6646832 Mon, 23 Dec 2024 17:11:29 GMT Expired Expired
537f7de Mon, 23 Dec 2024 17:18:10 GMT Cloud Enterprise

suejung-sentry
suejung-sentry approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! one question

src/pages/SyncProviderPage/SyncProviderPage.tsx Show resolved Hide resolved
@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (7200eea) to head (537f7de).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3573   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14563    14563           
  Branches     4151     4150    -1     
=======================================
  Hits        14418    14418           
  Misses        138      138           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/SyncProviderPage/SyncProviderPage.tsx 100.00% <100.00%> (ø)
src/services/config/SyncProvidersQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <100.00%> (ø)
Services 99.36% <100.00%> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7200eea...537f7de. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 3c674b5 Dec 23, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2962-migrate-useSyncProviders-to-tsqv5 branch December 23, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suejung-sentry suejung-sentry suejung-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @suejung-sentry