chore: Migrate useSelfHostedSeatsConfig to TS Query V5 #3580
Conversation
Bundle ReportChanges will increase total bundle size by 481 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 481 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14549 14554 +5
Branches 4150 4149 -1
=======================================
+ Hits 14404 14409 +5
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14549 14554 +5
Branches 4143 4142 -1
=======================================
+ Hits 14404 14409 +5
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14549 14554 +5
Branches 4150 4149 -1
=======================================
+ Hits 14404 14409 +5
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14549 14554 +5
Branches 4150 4142 -8
=======================================
+ Hits 14404 14409 +5
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
| }, | ||
| onSettled: () => { | ||
| queryClient.invalidateQueries(['SelfHostedCurrentUser']) | ||
| queryClient.invalidateQueries(['Seats']) | ||
| queryClientV5.invalidateQueries( | ||
| SelfHostedSeatsConfigQueryOpts({ provider }).queryKey |
There was a problem hiding this comment.
just making sure - is this provider key used in the lookup case-sensitive at all? Just in case that misses hits between like GITHUB, github, .. Oh and I guess also the shorthand like gh.
There was a problem hiding this comment.
yes it would be case sensitive, however the data fetching query key is also case sensitive so they would align on that level and ensure that the correct value in the cache gets cleared.
nicholas-codecov
force-pushed
the
gh-eng-2961-chore-migrate-useSelfHostedSeatsConfig-to-tsqv5
branch
from
ff5cd4f to
5909ba2
Compare
nicholas-codecov
deleted the
gh-eng-2961-chore-migrate-useSelfHostedSeatsConfig-to-tsqv5
branch
Description
This PR migrates the
useSelfHostedSeatsConfigto the TS Query V5 queryOptions versionSelfHostedSeatsConfigQueryOptsTicket: codecov/engineering-team#2961
Notable Changes
useSelfHostedSeatsConfigtoSelfHostedSeatsConfigQueryOptsSeatDetails,ActivationBanner,ActivationRequiredSelfHosted,ActivationRequiredSelfHostedProfiletests