-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Copy when changing plan from free plan #3594
Conversation
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3594 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 810 810
Lines 14569 14569
Branches 4150 4143 -7
=======================================
Hits 14409 14409
Misses 153 153
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3594 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 810 810
Lines 14569 14569
Branches 4143 4143
=======================================
Hits 14409 14409
Misses 153 153
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3594 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 810 810
Lines 14569 14569
Branches 4143 4143
=======================================
Hits 14409 14409
Misses 153 153
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3594 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 810 810
Lines 14569 14569
Branches 4150 4143 -7
=======================================
Hits 14409 14409
Misses 153 153
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Description
Free Plan has no billing cycle so we shouldn't say "Changing plan from monthly to annual" if the user wants to upgrade to an annual plan.
We just need to add the "isFreePlan" check to this function and rest we get for free.
Screenshots
BEFORE
AFTER
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.