Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy when changing plan from free plan #3594

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Dec 18, 2024

Description

Free Plan has no billing cycle so we shouldn't say "Changing plan from monthly to annual" if the user wants to upgrade to an annual plan.

We just need to add the "isFreePlan" check to this function and rest we get for free.

Screenshots

BEFORE
Screenshot 2024-12-18 at 2 55 23 PM

AFTER
Screenshot 2024-12-18 at 2 54 25 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Dec 18, 2024

Bundle Report

Changes will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.05MB 4 bytes (0.0%) ⬆️
gazebo-staging-system 6.0MB 4 bytes (0.0%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3594   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         810      810           
  Lines       14569    14569           
  Branches     4150     4143    -7     
=======================================
  Hits        14409    14409           
  Misses        153      153           
  Partials        7        7           
Files with missing lines Coverage Δ
...dePlanPage/UpgradeForm/UpdateBlurb/UpdateBlurb.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.57% <100.00%> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbcacb...f9bf896. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (9cbcacb) to head (f9bf896).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3594   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         810      810           
  Lines       14569    14569           
  Branches     4143     4143           
=======================================
  Hits        14409    14409           
  Misses        153      153           
  Partials        7        7           
Files with missing lines Coverage Δ
...dePlanPage/UpgradeForm/UpdateBlurb/UpdateBlurb.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.57% <100.00%> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbcacb...f9bf896. Read the comment docs.

Copy link

codecov-public-qa bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (9cbcacb) to head (f9bf896).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3594   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         810      810           
  Lines       14569    14569           
  Branches     4143     4143           
=======================================
  Hits        14409    14409           
  Misses        153      153           
  Partials        7        7           
Files with missing lines Coverage Δ
...dePlanPage/UpgradeForm/UpdateBlurb/UpdateBlurb.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.57% <100.00%> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbcacb...f9bf896. Read the comment docs.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (9cbcacb) to head (f9bf896).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3594   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         810      810           
  Lines       14569    14569           
  Branches     4150     4143    -7     
=======================================
  Hits        14409    14409           
  Misses        153      153           
  Partials        7        7           
Files with missing lines Coverage Δ
...dePlanPage/UpgradeForm/UpdateBlurb/UpdateBlurb.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.57% <100.00%> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbcacb...f9bf896. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f9bf896 Wed, 18 Dec 2024 23:00:09 GMT Cloud Enterprise

Copy link

codecov bot commented Dec 18, 2024

Bundle Report

Changes will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 4 bytes (0.0%) ⬆️
gazebo-production-system-esm 6.05MB 4 bytes (0.0%) ⬆️

@ajay-sentry ajay-sentry added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 73a32da Dec 19, 2024
62 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/fix-copy-if-free-plan-no-billing-cycle branch December 19, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants