Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add coverage generation step to CircleCI and OtherCI onboarding #3596

Merged

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Dec 19, 2024

This PR adds the framework coverage generation step from GHA to circle ci and other ci onboarding. To facilitate this, I pulled the OutputCoverageStep component and the FrameworkInstruction definition out of the GHA directory up a level into the shared onboarding directory and made the necessary changes to GHA onboarding.

Closes codecov/engineering-team#2697

Screenshot 2024-12-19 at 10 52 36 Screenshot 2024-12-19 at 10 52 45

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review December 19, 2024 15:52
@codecov-staging
Copy link

codecov-staging bot commented Dec 19, 2024

Bundle Report

Changes will increase total bundle size by 1.01kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.05MB 505 bytes (0.01%) ⬆️
gazebo-staging-system 6.0MB 506 bytes (0.01%) ⬆️

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (ed55d2f) to head (6d7bdaa).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   98.90%   98.88%   -0.02%     
==========================================
  Files         810      811       +1     
  Lines       14569    14576       +7     
  Branches     4143     4150       +7     
==========================================
+ Hits        14409    14414       +5     
- Misses        153      155       +2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 92.59% <100.00%> (-7.41%) ⬇️
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <100.00%> (ø)
...verageOnboarding/GitHubActions/WorkflowYMLStep.tsx 90.90% <ø> (ø)
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.tsx 100.00% <100.00%> (ø)
...boarding/OutputCoverageStep/OutputCoverageStep.tsx 100.00% <ø> (ø)
...ge/CoverageOnboarding/UseFrameworkInstructions.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.55% <100.00%> (-0.03%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed55d2f...6d7bdaa. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (ed55d2f) to head (6d7bdaa).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   98.90%   98.88%   -0.02%     
==========================================
  Files         810      811       +1     
  Lines       14569    14576       +7     
  Branches     4143     4143              
==========================================
+ Hits        14409    14414       +5     
- Misses        153      155       +2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 92.59% <100.00%> (-7.41%) ⬇️
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <100.00%> (ø)
...verageOnboarding/GitHubActions/WorkflowYMLStep.tsx 90.90% <ø> (ø)
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.tsx 100.00% <100.00%> (ø)
...boarding/OutputCoverageStep/OutputCoverageStep.tsx 100.00% <ø> (ø)
...ge/CoverageOnboarding/UseFrameworkInstructions.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.55% <100.00%> (-0.03%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed55d2f...6d7bdaa. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   99.01%   99.00%   -0.02%     
==========================================
  Files         809      810       +1     
  Lines       14550    14557       +7     
  Branches     4146     4139       -7     
==========================================
+ Hits        14407    14412       +5     
- Misses        136      138       +2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 92.59% <100.00%> (-7.41%) ⬇️
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <100.00%> (ø)
...verageOnboarding/GitHubActions/WorkflowYMLStep.tsx 90.90% <ø> (ø)
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.tsx 100.00% <100.00%> (ø)
...boarding/OutputCoverageStep/OutputCoverageStep.tsx 100.00% <ø> (ø)
...ge/CoverageOnboarding/UseFrameworkInstructions.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <100.00%> (-0.03%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.31% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee8ba5...32d8aeb. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (2ee8ba5) to head (32d8aeb).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   99.01%   99.00%   -0.02%     
==========================================
  Files         809      810       +1     
  Lines       14550    14557       +7     
  Branches     4146     4139       -7     
==========================================
+ Hits        14407    14412       +5     
- Misses        136      138       +2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 92.59% <100.00%> (-7.41%) ⬇️
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <100.00%> (ø)
...verageOnboarding/GitHubActions/WorkflowYMLStep.tsx 90.90% <ø> (ø)
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.tsx 100.00% <100.00%> (ø)
...boarding/OutputCoverageStep/OutputCoverageStep.tsx 100.00% <ø> (ø)
...ge/CoverageOnboarding/UseFrameworkInstructions.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <100.00%> (-0.03%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.31% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee8ba5...32d8aeb. Read the comment docs.

Copy link

codecov bot commented Dec 19, 2024

Bundle Report

Changes will decrease total bundle size by 45 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 22 bytes (-0.0%) ⬇️
gazebo-production-system-esm 6.05MB 23 bytes (-0.0%) ⬇️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Dec 19, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
6d7bdaa Thu, 19 Dec 2024 15:57:19 GMT Expired Expired
3263fdc Thu, 19 Dec 2024 20:30:56 GMT Expired Expired
32d8aeb Thu, 19 Dec 2024 20:39:33 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/add-coverage-step-to-cci-and-otherci branch from 6d7bdaa to 3263fdc Compare December 19, 2024 20:25
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 96d9efe Dec 19, 2024
51 of 54 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/add-coverage-step-to-cci-and-otherci branch December 19, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coverage report generation step to Circle CI and Codecov CLI steps in /new
3 participants