-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add coverage generation step to CircleCI and OtherCI onboarding #3596
feat: Add coverage generation step to CircleCI and OtherCI onboarding #3596
Conversation
Bundle ReportChanges will increase total bundle size by 1.01kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3596 +/- ##
==========================================
- Coverage 98.90% 98.88% -0.02%
==========================================
Files 810 811 +1
Lines 14569 14576 +7
Branches 4143 4150 +7
==========================================
+ Hits 14409 14414 +5
- Misses 153 155 +2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3596 +/- ##
==========================================
- Coverage 98.90% 98.88% -0.02%
==========================================
Files 810 811 +1
Lines 14569 14576 +7
Branches 4143 4143
==========================================
+ Hits 14409 14414 +5
- Misses 153 155 +2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3596 +/- ##
==========================================
- Coverage 99.01% 99.00% -0.02%
==========================================
Files 809 810 +1
Lines 14550 14557 +7
Branches 4146 4139 -7
==========================================
+ Hits 14407 14412 +5
- Misses 136 138 +2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3596 +/- ##
==========================================
- Coverage 99.01% 99.00% -0.02%
==========================================
Files 809 810 +1
Lines 14550 14557 +7
Branches 4146 4139 -7
==========================================
+ Hits 14407 14412 +5
- Misses 136 138 +2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 45 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
6d7bdaa
to
3263fdc
Compare
This PR adds the framework coverage generation step from GHA to circle ci and other ci onboarding. To facilitate this, I pulled the OutputCoverageStep component and the FrameworkInstruction definition out of the GHA directory up a level into the shared onboarding directory and made the necessary changes to GHA onboarding.
Closes codecov/engineering-team#2697