ref: Migrate gazebo from isTrialPlan helper to GQL property #3608
Conversation
| @@ -72,18 +70,17 @@ const TrialBanner: React.FC = () => { | |||
| return null | |||
| } | |||
|
|
|||
| // user is not on a free plan, trial is currently on going | |||
There was a problem hiding this comment.
comment was misleading, technically its checking for if the user is on the trial plan specifically, rather than just "not on a free plan"
Bundle ReportChanges will decrease total bundle size by 83 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 83 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3608 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14548 14543 -5
Branches 4143 4149 +6
==========================================
- Hits 14403 14398 -5
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3608 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14548 14543 -5
Branches 4143 4142 -1
==========================================
- Hits 14403 14398 -5
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3608 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14548 14543 -5
Branches 4150 4142 -8
==========================================
- Hits 14403 14398 -5
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3608 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14548 14543 -5
Branches 4143 4149 +6
==========================================
- Hits 14403 14398 -5
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| @@ -42,14 +42,6 @@ export function isSentryPlan(plan?: PlanName | null) { | |||
| return false | |||
| } | |||
|
|
|||
| export function isTrialPlan(plan?: PlanName | null) { | |||
Description
Part of milestone 2 for streamlining plan creation: codecov/engineering-team#2989
This PR just removes all the instances of isTrialPlan for the GQL property with the same name.
There are a few tests where I update the hard-coded string to use the const as well, but otherwise this PR is basically just "drop-in replacement" stuff
Closes codecov/engineering-team#3004
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.