Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve Sentry issue fetching in MissingDesignatedAdmins Without a Provider #3612

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Resolve Sentry issue fetching in MissingDesignatedAdmins Without a Provider #3612

wants to merge 3 commits into from

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR aims to resolve this Sentry issue, which is caused by the provider not being defined as there are some cases where the GlobalBanners can be rendered when no provider is present.

I've updated the Gazebo Guidelines to cover these cases specifically.

Notable Changes

  • Create small wrapper for MissingDesignatedAdmins to conditionally fetch
  • Clean up tests removing Query V4 things

@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 109 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 59 bytes (-0.0%) ⬇️
gazebo-production-system-esm 6.05MB 50 bytes (-0.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Dec 27, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 109 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.05MB 50 bytes (-0.0%) ⬇️
gazebo-staging-system 6.0MB 59 bytes (-0.0%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (c87e433) to head (16f49f6).

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3612      +/-   ##
==========================================
- Coverage   99.00%   99.00%   -0.01%     
==========================================
  Files         810      810              
  Lines       14549    14548       -1     
  Branches     4150     4143       -7     
==========================================
- Hits        14404    14403       -1     
  Misses        138      138              
  Partials        7        7
Files with missing lines Coverage Δ
...issingDesignatedAdmins/MissingDesignatedAdmins.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.73% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.44% <100.00%> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87e433...16f49f6. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3612      +/-   ##
==========================================
- Coverage   99.00%   99.00%   -0.01%     
==========================================
  Files         810      810              
  Lines       14549    14548       -1     
  Branches     4143     4150       +7     
==========================================
- Hits        14404    14403       -1     
  Misses        138      138              
  Partials        7        7
Files with missing lines Coverage Δ
...issingDesignatedAdmins/MissingDesignatedAdmins.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.73% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.44% <100.00%> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87e433...16f49f6. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (c87e433) to head (16f49f6).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3612      +/-   ##
==========================================
- Coverage   99.00%   99.00%   -0.01%     
==========================================
  Files         810      810              
  Lines       14549    14548       -1     
  Branches     4150     4150              
==========================================
- Hits        14404    14403       -1     
  Misses        138      138              
  Partials        7        7
Files with missing lines Coverage Δ
...issingDesignatedAdmins/MissingDesignatedAdmins.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.73% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.44% <100.00%> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87e433...16f49f6. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
16f49f6 Fri, 27 Dec 2024 13:24:55 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (c87e433) to head (16f49f6).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3612      +/-   ##
==========================================
- Coverage   99.00%   99.00%   -0.01%     
==========================================
  Files         810      810              
  Lines       14549    14548       -1     
  Branches     4150     4150              
==========================================
- Hits        14404    14403       -1     
  Misses        138      138              
  Partials        7        7
Files with missing lines Coverage Δ
...issingDesignatedAdmins/MissingDesignatedAdmins.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.73% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.44% <100.00%> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87e433...16f49f6. Read the comment docs.

ajay-sentry
ajay-sentry reviewed Dec 27, 2024
View reviewed changes
src/shared/GlobalBanners/MissingDesignatedAdmins/MissingDesignatedAdmins.tsx

if (hideBanner) {
if (!config.IS_SELF_HOSTED || !provider || hasAdmins || isFetching) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we no longer need this !provider check either right?

ajay-sentry
ajay-sentry approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @ajay-sentry