CCAP-466 #960
Open
CCAP-466 #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
reviewed
Dec 20, 2024
| <tr> | ||
| <td>calendar</td> | ||
| <td> | ||
| <svg th:fragment="calendar" width="101" height="75" viewBox="0 0 101 75" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
friendly reminder to always add: aria-hidden="true"
enyia21
force-pushed
the
CCAP-466-Create-providerresponse-registration-home-provider-dob-screen
branch
from
1949f7d to
0c6cefd
Compare
analoo
reviewed
Dec 23, 2024
src/main/resources/flows-config.yaml
Outdated
| @@ -674,6 +674,8 @@ flow: | |||
| nextScreens: | |||
| - name: registration-home-provider-dob | |||
| registration-home-provider-dob: | |||
| crossFieldValidationAction: ValidateHomeProviderDateOfBirth | |||
| onPostAction: CreateProviderIdentityCheckDOB | |||
| condition: EnableProviderRegistration | |||
There was a problem hiding this comment.
I don't know if this is in the ticket but the design shows that only a subset of provider types should be able to see this screen
There was a problem hiding this comment.
I'll make the change
enyia21
force-pushed
the
CCAP-466-Create-providerresponse-registration-home-provider-dob-screen
branch
from
4bfc979 to
4d2b176
Compare
spokenbird
approved these changes
Dec 24, 2024
analoo
reviewed
Dec 24, 2024
| @@ -178,6 +178,11 @@ void LicenseExemptInProviderHomeFlow() { | |||
|
|
|||
| testPage.clickContinue(); | |||
| // registration-home-provider-dob | |||
| assertThat(testPage.getTitle()).isEqualTo(getEnMessage("registration-home-provider-dob.title")); | |||
There was a problem hiding this comment.
This is great! It should skip in the other flows (Licensed home, Licensed group home, Licensed day care, licensed exempt day care)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
CCAP-466
✍️ Description
registration-home-provider-dob-screenand the fields listed below:providerIdentityCheckDateOfBirthDayproviderIdentityCheckDateOfBirthMonthproviderIdentityCheckDateOfBirthYear📷 Design reference
Figma
✅ Completion tasks