Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPI PIP 625 incompatibility #5

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

taughz
Copy link

@taughz taughz commented Dec 20, 2024

Uploading tarballs with - instead of _ results in the following email sent to the uploader:

In the future, PyPI will require all newly uploaded source
distribution filenames to comply with PEP 625. Any source
distributions already uploaded will remain in place as-is and do not
need to be updated.

Specifically, your recent upload of 'package-name-0.0.1.tar.gz' is
incompatible with PEP 625 because it does not contain the normalized
project name 'package_name'.

In most cases, this can be resolved by upgrading the version of your
build tooling to a later version that supports PEP 625 and produces
compliant filenames.

@taughz
Copy link
Author

taughz commented Dec 20, 2024

I did not attempt to change stdeb related functionality. So those are still using setup.py. I'm mostly trying to make PyPI happy.

There is an assumption here that build has been installed. I was not sure how best to express that dependency. The CI workflow might need to be updated, for example here: https://github.com/colcon/ci/blob/17cac168e05b5c0d109a5e482eaeb60708b3307e/action.yaml#L17

@taughz taughz marked this pull request as draft December 20, 2024 16:51
Uploading tarballs with `-` instead of `_` results in the following
email sent to the uploader:

> In the future, PyPI will require all newly uploaded source
> distribution filenames to comply with PEP 625. Any source
> distributions already uploaded will remain in place as-is and do not
> need to be updated.

> Specifically, your recent upload of 'package-name-0.0.1.tar.gz' is
> incompatible with PEP 625 because it does not contain the normalized
> project name 'package_name'.

> In most cases, this can be resolved by upgrading the version of your
> build tooling to a later version that supports PEP 625 and produces
> compliant filenames.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant