Allow matching out-of-order arrays with .in_any_order #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our team also need this functionality. 👍 to be merged |
|
@aliismayilov It looks like the project managers haven't touched this repository in a few months... so, if you like, you can just use my fork for now! |
|
thanks @rusterholz !! |
| module Indifference | ||
| extend self | ||
|
|
||
| def toggle_indifference( toggle ) |
There was a problem hiding this comment.
Please omit spaces around arguments in the method signature.
rusterholz
changed the title
|
Bump! I incorporated your feedback from above in my latest commit. |
|
This would be very useful |
|
Is there an alternative for this functionality or plans to merge it? |
|
Stumbled on this today, what a fine vintage this PR is. Would be useful to us as well. |
|
Also stumbling across this just now. This would be very useful functionality. |
|
+1 from me too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team needed a way to reliably, consistently test the JSON returned by our API, despite the facts that:
For example, our API might respond with
{"objects":[{"id":1,"some_attribute":"foo"},{"id":2,"some_attribute":"bar"}]}and that would be totally valid, but it is just as likely to respond with{"objects":[{"id":2,"some_attribute":"bar"},{"id":1,"some_attribute":"foo"}]}instead, and that should also be valid.To allow the
be_json_eqlmatcher to match out-of-order arrays, I've added the chain method.in_any_order. It works by sorting each array in lexical order according to the JSON string representation of the element.You can also pass
falseto.in_any_orderif you want to, which then behaves as if you had not chained.in_any_orderat all (in case someone needs to determine indifference dynamically at runtime).Examples are available in the modified
be_json_eql_spec.rbfile. I also added some tests to ensure that this feature should work correctly when combined with the other features of this matcher.