Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacrs #28293

Merged
merged 16 commits into from
Dec 18, 2024
Merged

Add stacrs #28293

merged 16 commits into from
Dec 18, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Nov 20, 2024

A no-dependency Python package for STAC, using Rust under the hood! Repo at https://github.com/gadomski/stacrs

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

A no-dependency Python package for STAC, using Rust under the hood! Repo at https://github.com/stac-utils/stac-rs
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/stacrs/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/stacrs/recipe.yaml:

  • ❌ The top level meta key schema_version is unexpected
  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/stacrs/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

Silence conda-forge linter messag: `The top level meta key schema_version is unexpected`
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/stacrs/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/stacrs/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/stacrs/recipe.yaml) and found it was in an excellent condition.

@weiji14
Copy link
Member Author

weiji14 commented Nov 20, 2024

Getting this build error:

+ cargo-bundle-licenses --format yaml --output THIRDPARTY.yml
Error: `cargo metadata` exited with an error: error: package `$SRC_DIR/crates/cli` is listed in default-members but is not a member
for workspace at $SRC_DIR/Cargo.toml.

I downloaded the sdist (stacrs-0.2.2.tar.gz) from https://pypi.org/project/stacrs/0.2.2/#files, and saw that the Cargo.toml has these lines:

[workspace]
resolver = "2"
members = ["python"]
default-members = [
    "crates/api",
    "crates/cli",
    "crates/core",
    "crates/extensions",
]

These appear to be derived from https://github.com/stac-utils/stac-rs/blob/d13c0f474c1e3b2fc3854bdf60f10608b273c689/Cargo.toml#L13-L18. The 'crates/cli` folder is indeed missing in the sdist, so need to see how to handle this... See related thread at PyO3/maturin#2046

Edit: fixed in stac-utils/stac-rs#527.

@weiji14
Copy link
Member Author

weiji14 commented Nov 24, 2024

Note to self: was getting this error on openssl-sys during compilation at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1089429&view=logs&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff&l=1143:

   Compiling openssl-sys v0.9.104
   Compiling futures-channel v0.3.31
   Compiling futures-macro v0.3.31
   Compiling fnv v1.0.7
   Compiling semver v1.0.23
   Compiling base64 v0.22.1
   Compiling futures-io v0.3.31
   Compiling icu_locid_transform_data v1.5.0
   Compiling pin-utils v0.1.0
   Compiling futures-task v0.3.31
   Compiling futures-util v0.3.31
   Compiling icu_locid_transform v1.5.0
   Compiling http v1.1.0
   Compiling pyo3-build-config v0.22.6
The following warnings were emitted during compilation:
warning: [email protected]: configuring OpenSSL build: Command 'perl' not found. Is perl installed?
warning: [email protected]: openssl-src: failed to build OpenSSL from source
error: failed to run custom build command for `openssl-sys v0.9.104`
Caused by:
  process didn't exit successfully: `$SRC_DIR/target/release/build/openssl-sys-583d03d9a9661d2c/build-script-main` (exit status: 1)
...
...
...
  running cd "$SRC_DIR/target/x86_64-unknown-linux-gnu/release/build/openssl-sys-03c739d734f0bbb7/out/openssl-build/build/src" && env -u CROSS_COMPILE AR="$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-ar" CC="$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-cc" RANLIB="$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-ranlib" "perl" "./Configure" "--prefix=$SRC_DIR/target/x86_64-unknown-linux-gnu/release/build/openssl-sys-03c739d734f0bbb7/out/openssl-build/install" "--openssldir=/usr/local/ssl" "no-shared" "no-module" "no-ssl3" "no-tests" "no-comp" "no-zlib" "no-zlib-dynamic" "--libdir=lib" "no-md2" "no-rc5" "no-weak-ssl-ciphers" "no-camellia" "no-idea" "no-seed" "linux-x86_64" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-march=nocona" "-mtune=haswell" "-ftree-vectorize" "-fPIC" "-fstack-protector-strong" "-fno-plt" "-O2" "-ffunction-sections" "-pipe" "-isystem" "$PREFIX/include" "-fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/stacrs-0.3.0" "-fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix"
  cargo:warning=configuring OpenSSL build: Command 'perl' not found. Is perl installed?
  cargo:warning=openssl-src: failed to build OpenSSL from source
  --- stderr
  Error configuring OpenSSL build:
      Command 'perl' not found. Is perl installed?
      Command failed: cd "$SRC_DIR/target/x86_64-unknown-linux-gnu/release/build/openssl-sys-03c739d734f0bbb7/out/openssl-build/build/src" && env -u CROSS_COMPILE AR="$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-ar" CC="$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-cc" RANLIB="$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-ranlib" "perl" "./Configure" "--prefix=$SRC_DIR/target/x86_64-unknown-linux-gnu/release/build/openssl-sys-03c739d734f0bbb7/out/openssl-build/install" "--openssldir=/usr/local/ssl" "no-shared" "no-module" "no-ssl3" "no-tests" "no-comp" "no-zlib" "no-zlib-dynamic" "--libdir=lib" "no-md2" "no-rc5" "no-weak-ssl-ciphers" "no-camellia" "no-idea" "no-seed" "linux-x86_64" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-march=nocona" "-mtune=haswell" "-ftree-vectorize" "-fPIC" "-fstack-protector-strong" "-fno-plt" "-O2" "-ffunction-sections" "-pipe" "-isystem" "$PREFIX/include" "-fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/stacrs-0.3.0" "-fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix"
  warning: build failed, waiting for other jobs to finish...
  💥 maturin failed
    Caused by: Failed to build a native library through cargo

Fixed this in commit 1830fe3 by adding the OPENSSL_DIR and OPENSSL_NO_VENDOR environment variables, following what was done at #25709 (comment).

Fixes `warning: [email protected]: Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `c++` installed?`
@weiji14
Copy link
Member Author

weiji14 commented Nov 24, 2024

Managed to get libduckdb-sys to build on Linux/Windows with commit 473586f by adding - ${{ compiler("cxx") }}, but this doesn't work on macOS at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1089464&view=logs&j=dff6ff7b-316b-540a-5923-739df25f7012&t=2582809e-c3dc-5a5f-d883-fd3c8f9139aa&l=1621, getting an error like fatal error: 'cstdint' file not found:

   Compiling libduckdb-sys v1.0.0
   Compiling itertools v0.13.0
   Compiling wkt v0.11.1
   Compiling fluent-uri v0.1.4
   Compiling quick-xml v0.36.2
   Compiling thiserror-impl v2.0.3
   Compiling async-trait v0.1.83
   Compiling memoffset v0.9.1
   Compiling rust_decimal v1.36.0
   Compiling base64 v0.21.7
   Compiling humantime v2.1.0
   Compiling appendlist v1.4.0
   Compiling boon v0.6.0
   Compiling object_store v0.11.1
   Compiling geoarrow v0.3.0
   Compiling pest_derive v2.7.14
   Compiling stac-types v0.1.0
   Compiling strum_macros v0.25.3
   Compiling pyo3 v0.22.6
   Compiling pg_escape v0.1.1
   Compiling stac-derive v0.1.0
   Compiling async-stream-impl v0.3.6
   Compiling arrayvec v0.7.6
   Compiling async-stream v0.3.6
   Compiling stac v0.11.0
   Compiling cql2 v0.3.1
   Compiling strum v0.25.0
   Compiling pyo3-macros v0.22.6
   Compiling hashlink v0.8.4
   Compiling openssl v0.10.68
   Compiling indoc v2.0.5
   Compiling unindent v0.2.3
   Compiling fallible-streaming-iterator v0.1.9
   Compiling fallible-iterator v0.3.0
   Compiling cast v0.3.0
   Compiling foreign-types-shared v0.1.1
   Compiling foreign-types v0.3.2
   Compiling stac-api v0.6.2
   Compiling openssl-macros v0.1.1
   Compiling pythonize v0.22.0
The following warnings were emitted during compilation:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/ub_src_common_adbc_nanoarrow.cpp:7:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/common/adbc/nanoarrow/single_batch_array_stream.cpp:6:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include/duckdb/common/arrow/arrow_wrapper.hpp:11:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include/duckdb/common/helper.hpp:11:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include/duckdb/common/constants.hpp:14:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include/duckdb/common/unique_ptr.hpp:3:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include/duckdb/common/exception.hpp:12:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include/duckdb/common/exception_format_value.hpp:12:
warning: [email protected]: In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include/duckdb/common/hugeint.hpp:6:
warning: [email protected]: $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include/duckdb/common/typedefs.hpp:11:10: fatal error: 'cstdint' file not found
warning: [email protected]:    11 | #include <cstdint>
warning: [email protected]:       |          ^~~~~~~~~
warning: [email protected]: 1 error generated.
warning: [email protected]: ToolExecError: Command env -u IPHONEOS_DEPLOYMENT_TARGET "x86_64-apple-darwin13.4.0-clang++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "--target=x86_64-apple-macosx10.13" "-I" "duckdb" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/utf8proc" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/yyjson/include" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/libpg_query" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/fsst" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/mbedtls/library" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/lz4" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/mbedtls" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/mbedtls/include" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/re2" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/libpg_query/include" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/jaro_winkler/details" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/utf8proc/include" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/fmt/include" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/fastpforlib" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/tdigest" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/include" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/skiplist" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/httplib" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/fast_float" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/jaro_winkler" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/miniz" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/pcg" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/concurrentqueue" "-I" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/third_party/hyperloglog" "-march=core2" "-mtune=haswell" "-mssse3" "-ftree-vectorize" "-fPIC" "-fstack-protector-strong" "-O2" "-pipe" "-stdlib=libc++" "-fvisibility-inlines-hidden" "-fmessage-length=0" "-isystem" "$PREFIX/include" "-fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/stacrs-0.3.0" "-fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix" "-std=c++11" "-stdlib=libc++" "-stdlib=libstdc++" "-w" "-DDUCKDB_EXTENSION_AUTOINSTALL_DEFAULT=1" "-DDUCKDB_EXTENSION_AUTOLOAD_DEFAULT=1" "-o" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/dfaa9bfa9c631b3a-ub_src_common_adbc_nanoarrow.o" "-c" "$SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/ub_src_common_adbc_nanoarrow.cpp" with args x86_64-apple-darwin13.4.0-clang++ did not execute successfully (status code exit status: 1).cargo:warning=In file included from $SRC_DIR/target/x86_64-apple-darwin/release/build/libduckdb-sys-8dfe7d516d814ef9/out/duckdb/src/common/vector_operations/comparison_operators.cpp:7:

Need to see how to fix that. Am thinking about whether libduckdb-sys should actually be built separately 🤔

@gadomski
Copy link
Contributor

@weiji14 if the duckdb dependency is being a pain, I'd be open to removing it from the Python library. It's pretty experimental right now and could be more trouble than its worth.

@weiji14
Copy link
Member Author

weiji14 commented Nov 24, 2024

I saw a similar issue about cstdlib mentioned at conda-forge/ray-packages-feedstock#183 (comment), and the workaround was to downgrade to macos-12, but considering that macos-12 is meant to be deprecated on Azure next month (#27770), probably not good to downgrade from the default macos-13 to macos-12 here.

Let me try a newer MACOSX_SDK_VERSION - https://conda-forge.org/docs/maintainer/knowledge_base/#requiring-newer-macos-sdks, and see if it works before we think of yanking out libduckdb-sys. I'm surprised that https://github.com/duckdb/duckdb-rs/tree/v1.1.1 doesn't have CI for macOS, so don't really have a guide on what version to use (plus I don't have a macOS device). Might involve a bit of trial and error 🙂

Copy link
Member Author

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, compilation on macOS works now using MACOSX_SDK_VERSION=10.14 🎉

      Compiling stacrs v0.3.0 ($SRC_DIR)
       Finished `release` profile [optimized] target(s) in 12m 04s
   📖 Found type stub file at stacrs.pyi
   📦 Built wheel for CPython 3.12 to $SRC_DIR/target/wheels/stacrs-0.3.0-cp312-cp312-macosx_10_13_x86_64.whl
   $SRC_DIR/target/wheels/stacrs-0.3.0-cp312-cp312-macosx_10_13_x86_64.whl
   Building wheel for stacrs (pyproject.toml): finished with status 'done'
   Created wheel for stacrs: filename=stacrs-0.3.0-cp312-cp312-macosx_10_13_x86_64.whl size=16636665 sha256=2a6a47c278b33402e3282fc1853baf28a1432bfd7bda1c73da49c0be7008a3b8
   Stored in directory: /private/var/folders/p1/44pzfl0j2m301zzfb0fv0p380000gn/T/pip-ephem-wheel-cache-gb3wq8_j/wheels/01/22/fa/922df9bc9d1840c4c4b5f2153683491f3278d12edd0c165cd2
 Successfully built stacrs
 Installing collected packages: stacrs
 Successfully installed stacrs-0.3.0

Comment on lines 64 to 65
recipe-maintainers:
- weiji14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gadomski, would you like to be a conda-forge recipe maintainer for stacrs (need a yes/no answer)?

Suggested change
recipe-maintainers:
- weiji14
recipe-maintainers:
- gadomski
- weiji14

Copy link
Contributor

@gadomski gadomski Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I will, thanks for setting this up! If you have bandwidth, we could add this to the install instructions over on stacrs too.

@weiji14 weiji14 marked this pull request as ready for review November 25, 2024 18:34
@weiji14
Copy link
Member Author

weiji14 commented Nov 25, 2024

@conda-forge/help-rust @conda-forge/help-python ready for review!

@github-actions github-actions bot added the R label Nov 25, 2024
- python:
imports:
- stacrs
- requirements:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove calling pip check as a script, and add it under python:
https://prefix-dev.github.io/rattler-build/latest/reference/recipe_file/#python-tests

although I think pip_check defaults to true.

Copy link
Member Author

@weiji14 weiji14 Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ok, I tried it at commit 26563d8 but got the following error:

Error:   × Failed to parse recipe

Error:   × Parsing: missing field `script`
    ╭─[48:17]
 47 │           pip_check: true
 48 │ ╭─▶   - requirements:
 49 │ │         run:
 50 │ │           - pip
 51 │ │   
 52 │ ├─▶ about:
    · ╰──── here
 53 │       summary: A no-dependency Python package for STAC, using Rust under the hood.
    ╰────
  help: expected field `script` to be a list of commands

Maybe I should remove the requirements.run part, let me try that.

Edit: Yep, works now.

@weiji14
Copy link
Member Author

weiji14 commented Dec 16, 2024

@conda-forge/help-rust @conda-forge/help-python, gentle ping again to get this merged if possible. Builds are passing on all platforms now.

@xhochy xhochy merged commit 0aee449 into conda-forge:main Dec 18, 2024
7 checks passed
@weiji14 weiji14 deleted the add-stacrs branch December 18, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants