-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stacrs #28293
Add stacrs #28293
Conversation
A no-dependency Python package for STAC, using Rust under the hood! Repo at https://github.com/stac-utils/stac-rs
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/stacrs/recipe.yaml:
For recipes/stacrs/recipe.yaml:
|
Silence conda-forge linter messag: `The top level meta key schema_version is unexpected`
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/stacrs/recipe.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Getting this build error:
I downloaded the sdist (stacrs-0.2.2.tar.gz) from https://pypi.org/project/stacrs/0.2.2/#files, and saw that the Cargo.toml has these lines:
These appear to be derived from https://github.com/stac-utils/stac-rs/blob/d13c0f474c1e3b2fc3854bdf60f10608b273c689/Cargo.toml#L13-L18. The 'crates/cli` folder is indeed missing in the sdist, so need to see how to handle this... See related thread at PyO3/maturin#2046 Edit: fixed in stac-utils/stac-rs#527. |
New repository at https://github.com/gadomski/stacrs
Fix `openssl-src: failed to build OpenSSL from source`
Note to self: was getting this error on
Fixed this in commit 1830fe3 by adding the |
Fixes `warning: [email protected]: Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `c++` installed?`
Managed to get
Need to see how to fix that. Am thinking about whether |
@weiji14 if the duckdb dependency is being a pain, I'd be open to removing it from the Python library. It's pretty experimental right now and could be more trouble than its worth. |
I saw a similar issue about cstdlib mentioned at conda-forge/ray-packages-feedstock#183 (comment), and the workaround was to downgrade to macos-12, but considering that macos-12 is meant to be deprecated on Azure next month (#27770), probably not good to downgrade from the default macos-13 to macos-12 here. Let me try a newer |
Up from default 10.13.
This reverts commit 26563d8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, compilation on macOS works now using MACOSX_SDK_VERSION=10.14
🎉
Compiling stacrs v0.3.0 ($SRC_DIR)
Finished `release` profile [optimized] target(s) in 12m 04s
📖 Found type stub file at stacrs.pyi
📦 Built wheel for CPython 3.12 to $SRC_DIR/target/wheels/stacrs-0.3.0-cp312-cp312-macosx_10_13_x86_64.whl
$SRC_DIR/target/wheels/stacrs-0.3.0-cp312-cp312-macosx_10_13_x86_64.whl
Building wheel for stacrs (pyproject.toml): finished with status 'done'
Created wheel for stacrs: filename=stacrs-0.3.0-cp312-cp312-macosx_10_13_x86_64.whl size=16636665 sha256=2a6a47c278b33402e3282fc1853baf28a1432bfd7bda1c73da49c0be7008a3b8
Stored in directory: /private/var/folders/p1/44pzfl0j2m301zzfb0fv0p380000gn/T/pip-ephem-wheel-cache-gb3wq8_j/wheels/01/22/fa/922df9bc9d1840c4c4b5f2153683491f3278d12edd0c165cd2
Successfully built stacrs
Installing collected packages: stacrs
Successfully installed stacrs-0.3.0
recipes/stacrs/recipe.yaml
Outdated
recipe-maintainers: | ||
- weiji14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gadomski, would you like to be a conda-forge recipe maintainer for stacrs
(need a yes/no answer)?
recipe-maintainers: | |
- weiji14 | |
recipe-maintainers: | |
- gadomski | |
- weiji14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I will, thanks for setting this up! If you have bandwidth, we could add this to the install instructions over on stacrs too.
@conda-forge/help-rust @conda-forge/help-python ready for review! |
recipes/stacrs/recipe.yaml
Outdated
- python: | ||
imports: | ||
- stacrs | ||
- requirements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove calling pip check
as a script, and add it under python
:
https://prefix-dev.github.io/rattler-build/latest/reference/recipe_file/#python-tests
although I think pip_check
defaults to true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok, I tried it at commit 26563d8 but got the following error:
Error: × Failed to parse recipe
Error: × Parsing: missing field `script`
╭─[48:17]
47 │ pip_check: true
48 │ ╭─▶ - requirements:
49 │ │ run:
50 │ │ - pip
51 │ │
52 │ ├─▶ about:
· ╰──── here
53 │ summary: A no-dependency Python package for STAC, using Rust under the hood.
╰────
help: expected field `script` to be a list of commands
Maybe I should remove the requirements.run
part, let me try that.
Edit: Yep, works now.
@conda-forge/help-rust @conda-forge/help-python, gentle ping again to get this merged if possible. Builds are passing on all platforms now. |
A no-dependency Python package for STAC, using Rust under the hood! Repo at https://github.com/gadomski/stacrs
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).