Add s3 handling for maven-metadata #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jainruchir <[email protected]>
fzakaria
approved these changes
Dec 12, 2024
Comment on lines
374
to
375
| * Attempts to download the file at the given targetUrl. Valid protocols are: http(s) & file at | ||
| * the moment. |
| try { | ||
| URI s3Uri = new URI(targetUrl); | ||
| String bucketName = s3Uri.getHost(); | ||
| String path = s3Uri.getPath().substring(1); |
There was a problem hiding this comment.
nit: i would path -> key better naming for S3.
I would break out this parsing maybe into URI -> S3Object
| } | ||
| return Optional.of( | ||
| com.google.common.io.Files.asCharSource(path.toFile(), StandardCharsets.UTF_8) | ||
| .read()); |
There was a problem hiding this comment.
Nit: Java11+ has String content = Files.readString(path, encoding);
| ); | ||
| } | ||
| catch (HttpResponseException e) { | ||
| CharStreams.toString( |
There was a problem hiding this comment.
new InputStreamReader(response.getContent(), StandardCharsets.UTF_8)));```
Might be nice to make this a small utility function.
fzakaria
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to use s3 as a maven registry, but the original
maven-metadata.xmlcode that we added didn't support s3. This adds that support.I tested locally with an s3 bucket and using
--define maven_repo=s3://{bucket}The reason for a lot of the line changes was running the formatter
bazel run scripts:format. I did revert the untouched files. We should probably update bazel-contrib#1260