-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TMT: Updates to account for official CentOS Stream and OSCI gating. #345
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request updates the CI and deployment configurations to support multiple architectures and improve test reliability. It also fixes the podman source extraction command in the test script. State diagram: Updated gating workflowstateDiagram-v2
[*] --> BuildInitiated
BuildInitiated --> BuildCompleted
BuildCompleted --> TestingGate
TestingGate --> StableGate
state TestingGate {
[*] --> RunTests
RunTests --> CheckResults
CheckResults --> PassedTesting : Pass
CheckResults --> FailedTesting : Fail
PassedTesting --> [*]
FailedTesting --> [*]
}
state StableGate {
[*] --> RunStableTests
RunStableTests --> CheckStableResults
CheckStableResults --> PassedStable : Pass
CheckStableResults --> FailedStable : Fail
PassedStable --> [*]
FailedStable --> [*]
}
StableGate --> [*]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
9e337a3
to
7441a24
Compare
c647aae
to
cbfb6db
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
c9a5264
to
cbfb6db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lsm5 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The removal of e2e tests from podman-tests.sh needs explanation. Was this intentional? If so, please provide rationale for removing this test coverage.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Intentional. Running e2e tests by fetching sources with If we absolutely need to run podman e2e tests, we should fetch sources using a |
`dnf download` on CentOS Stream ends up downloading all rpm versions of a package from all available repos instead of only the latest rpm. This leads to more (unnecessary) complications in the test script. Things are a lot simpler if we directly test using the `podman-tests` package. This means we'll have to disable podman e2e tests and only do system tests but that shouldn't be too big a problem. A better way to run podman e2e tests would be by creating a `podman-src` rpm subpackage that'll install all the rpm sources. Signed-off-by: Lokesh Mandvekar <[email protected]>
container-selinux maybe noarch but it would help to have aarch64 visibility to ensure everything works, especially RE: podman. Signed-off-by: Lokesh Mandvekar <[email protected]>
OSCI will gate on TMT tests for CentOS Stream. Signed-off-by: Lokesh Mandvekar <[email protected]>
0589ed8
to
e3d3645
Compare
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
e3d3645
to
7964f54
Compare
See individual commits for details.
Summary by Sourcery
Update testing and gating configurations to include CentOS Stream and OSCI.
CI:
Tests: