Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMT: Updates to account for official CentOS Stream and OSCI gating. #345

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Dec 13, 2024

See individual commits for details.

Summary by Sourcery

Update testing and gating configurations to include CentOS Stream and OSCI.

CI:

  • Add support for CentOS Stream 9 and 10, Fedora ELN, as well as aarch64 architecture in the Copr build jobs.

Tests:

  • Update the test matrix to include testing on CentOS Stream 9 and 10 for stable and testing releases using Bodhi and OSCI.

Copy link

sourcery-ai bot commented Dec 13, 2024

Reviewer's Guide by Sourcery

This pull request updates the CI and deployment configurations to support multiple architectures and improve test reliability. It also fixes the podman source extraction command in the test script.

State diagram: Updated gating workflow

stateDiagram-v2
    [*] --> BuildInitiated
    BuildInitiated --> BuildCompleted
    BuildCompleted --> TestingGate
    TestingGate --> StableGate

    state TestingGate {
        [*] --> RunTests
        RunTests --> CheckResults
        CheckResults --> PassedTesting : Pass
        CheckResults --> FailedTesting : Fail
        PassedTesting --> [*]
        FailedTesting --> [*]
    }

    state StableGate {
        [*] --> RunStableTests
        RunStableTests --> CheckStableResults
        CheckStableResults --> PassedStable : Pass
        CheckStableResults --> FailedStable : Fail
        PassedStable --> [*]
        FailedStable --> [*]
    }

    StableGate --> [*]
Loading

File-Level Changes

Change Details Files
Updated CI configurations to include additional architecture targets for Fedora and CentOS Stream builds.
  • Added aarch64 architecture to Fedora and CentOS Stream build targets in the packit configuration file.
  • Updated Fedora and CentOS Stream build targets to include x86_64 architecture explicitly in the packit configuration file.
.packit.yaml
Added a new gating rule for OSCI compose gate.
  • Added a PassingTestCaseRule for osci.brew-build.tier0.functional test case in the gating configuration for RHEL products.
  • Added osci_compose_gate to the decision context in the gating configuration.
rpm/gating.yaml
Fixed the podman source extraction command in the test script.
  • Removed the logic for downloading and extracting podman source code from SRPM.
  • Removed the logic for checking version matching between podman-tests RPM and podman SRPM.
  • Removed the logic for running e2e tests based on the TEST_TYPE argument.
  • Simplified the script to directly run podman system tests using bats.
test/podman-tests.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lsm5 lsm5 force-pushed the c9s-update-gating branch 2 times, most recently from 9e337a3 to 7441a24 Compare December 16, 2024 08:05
@lsm5 lsm5 force-pushed the c9s-update-gating branch 3 times, most recently from c647aae to cbfb6db Compare December 26, 2024 09:46
@lsm5 lsm5 mentioned this pull request Dec 26, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5 lsm5 force-pushed the c9s-update-gating branch from c9a5264 to cbfb6db Compare December 31, 2024 11:41
@lsm5 lsm5 marked this pull request as ready for review December 31, 2024 12:14
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lsm5 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The removal of e2e tests from podman-tests.sh needs explanation. Was this intentional? If so, please provide rationale for removing this test coverage.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lsm5
Copy link
Member Author

lsm5 commented Dec 31, 2024

Hey @lsm5 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The removal of e2e tests from podman-tests.sh needs explanation. Was this intentional? If so, please provide rationale for removing this test coverage.

Intentional. Running e2e tests by fetching sources with dnf download ... is a PITA on CentOS and imho not worth the hassle. We are running system tests anyway. FWIW, bodhi updates for the podman package only run its system tests.

If we absolutely need to run podman e2e tests, we should fetch sources using a podman-src / podman-devel subpackage.

@lsm5 lsm5 marked this pull request as draft December 31, 2024 13:20
lsm5 added 3 commits December 31, 2024 19:00
`dnf download` on CentOS Stream ends up downloading all rpm versions of
a package from all available repos instead of only the latest rpm. This
leads to more (unnecessary) complications in the test script.

Things are a lot simpler if we directly test using the `podman-tests`
package. This means we'll have to disable podman e2e tests and only do
system tests but that shouldn't be too big a problem.

A better way to run podman e2e tests would be by creating a `podman-src`
rpm subpackage that'll install all the rpm sources.

Signed-off-by: Lokesh Mandvekar <[email protected]>
container-selinux maybe noarch but it would help to have aarch64
visibility to ensure everything works, especially RE: podman.

Signed-off-by: Lokesh Mandvekar <[email protected]>
OSCI will gate on TMT tests for CentOS Stream.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the c9s-update-gating branch 2 times, most recently from 0589ed8 to e3d3645 Compare December 31, 2024 14:08
@lsm5 lsm5 force-pushed the c9s-update-gating branch from e3d3645 to 7964f54 Compare December 31, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant