Support network scoped service aliases #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisongmin
force-pushed
the
feat-support-network-scoped-aliases
branch
4 times, most recently
from
6e388ec to
a955bc8
Compare
lisongmin
force-pushed
the
feat-support-network-scoped-aliases
branch
from
a955bc8 to
69ee8ab
Compare
lisongmin
force-pushed
the
feat-support-network-scoped-aliases
branch
4 times, most recently
from
067b878 to
873c1c0
Compare
p12tic
reviewed
Dec 18, 2024
Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
See https://docs.docker.com/reference/compose-file/services/#network_mode Signed-off-by: Povilas Kanapickas <[email protected]>
This commit takes into account that network_mode won't have networks attribute set, accordingly get_net_args_from_network_mode() can calculate complete net_args easily. Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
Signed-off-by: Povilas Kanapickas <[email protected]>
Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
Note that multiple_nets is now guaranteed to be not empty in processing stage. Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
The behavior has not changed, single-network has a special case. Modified-by: Povilas Kanapickas <[email protected]> Signed-off-by: Songmin Li <[email protected]>
p12tic
force-pushed
the
feat-support-network-scoped-aliases
branch
from
873c1c0 to
681d636
Compare
|
@lisongmin Thanks for the PR. I will write several comments, but overall it looks good. Please note, that such a PR where all changes are added as a single commit is extremely hard to review. Refactoring is mixed with functionality changes and as a result I would have to replay everything in my head. I've split the PR in small commits that refactor one thing at a time. The end result is almost the same except several deliberate changes. The functionality changes are then way smaller and way easier to review. |
p12tic
reviewed
Dec 18, 2024
p12tic
reviewed
Dec 18, 2024
p12tic
reviewed
Dec 18, 2024
p12tic
reviewed
Dec 18, 2024
|
I'm looking into 22454fc to review functionality changes. |
lisongmin
force-pushed
the
feat-support-network-scoped-aliases
branch
from
681d636 to
f050dac
Compare
|
Done. Sorry for the poor PR, thanks for your patience in checking the codes. I learn a lot from it. |
Signed-off-by: Songmin Li <[email protected]>
Signed-off-by: Songmin Li <[email protected]>
When using bridge mode, podman-compose will use the default `podman` network. We do not need to create this network, so just return as other network_mode. Signed-off-by: Songmin Li <[email protected]>
p12tic
force-pushed
the
feat-support-network-scoped-aliases
branch
from
f050dac to
346f7a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support network scoped aliases, we using the
aliasoption in--network.Since the
--network-aliaswill override thealiasset by--network,we do not using the
--network-aliasany more. All aliases will be setvia
--network.