Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull latest image for deploying docker compose buildpack #4686

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

tflanagan
Copy link

Changes

  • Pull latest images when using docker compose buildpacks to deploy application

Issues

I've been modifying the container manually to fix this for my own use of Coolify, but I figured I'd push it upstream and see what happens.

(not a docker expert)

@djsisson
Copy link
Contributor

@tflanagan have you tested this?

im curious for a couple of reasons, first , what would pulling an image before its been built do?
the very next section does a build command with --pull anyway
unless you run custom build commands?

the next reason is, the uuid of the image being build is always the projectid, so i never see more than one image in images list, as they all have same id-name:latest
so i dont see this issue

so i assume you are using custom buuild commands and not passing the project name, so it generates a new one each time, hence the multiple images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants