Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FA24 contributors in README #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shengle-Dai
Copy link
Collaborator

Updating FA24 contributors

This is my first PR as part of the onboarding process to get familiar with branch operations and PR workflows in DTI. I have intentionally left some members unlisted to allow other new developers the opportunity to contribute to the README through their own PRs.

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2024

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 13.

@shah-esha shah-esha closed this Oct 7, 2024
@shah-esha shah-esha reopened this Oct 7, 2024
@3TTemi
Copy link
Contributor

3TTemi commented Oct 8, 2024

Looks great! This is an good PR to start getting familiar with Git and our developer workflow. For future pull requests, I recommend following the default pull request template, which includes sections like "Summary," "Remaining TODOs," "Test Plan," "Notes," "Blockers," and "Breaking Changes." While this PR doens't apply to most of these categories, some sections are required. You can simply just put down "Not Applicable" where relevant and jsut make sure to fill in the summary in the summary. This keeps our PRs consistent and easy to read.

Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Make sure to always pull main before doing the final merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants