Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagster_azure: do not import fake implementations by default #26754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

futurwasfree
Copy link

Related to issue #26733

Summary & Motivation

Currently when I import the following symbols in my production setup:

from dagster_azure.adls2.io_manager import adls2_pickle_io_manager
from dagster_azure.adls2.resources import adls2_resource

I'm also getting all the fake_adls2_resources imported, as it's described in adls2/init.py:

from dagster_azure.adls2.fake_adls2_resource import (
    FakeADLS2Resource as FakeADLS2Resource,
    FakeADLS2ServiceClient as FakeADLS2ServiceClient,
    fake_adls2_resource as fake_adls2_resource,
This easily adds 0.3-0.5 seconds to overall import/startup time.

How I Tested These Changes

python -X importtime definitions.py
before and after the change

Changelog

Insert changelog entry or delete this section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dagster_azure: be able to import without fake impls
1 participant