Fix lint changes that would not work on older swift version

Sources/Danger/DangerDSL.swift

@@ -57,10 +57,12 @@ public struct DangerDSL: Decodable {
 
         // Setup the OctoKit once all other
         if runningOnGithub {
-            let config = if let baseURL = settings.github.baseURL {
-                TokenConfiguration(settings.github.accessToken, url: baseURL)
+            let config: TokenConfiguration
+
+            if let baseURL = settings.github.baseURL {
+                config = TokenConfiguration(settings.github.accessToken, url: baseURL)
             } else {
-                TokenConfiguration(settings.github.accessToken)
+                config = TokenConfiguration(settings.github.accessToken)
             }
 
             github.api = Octokit(config)

Sources/Danger/GitDiff.swift

@@ -118,14 +118,16 @@ struct DiffParser {
         let filePath = lines.first?.split(separator: " ").first(where: { $0.starts(with: "b/") })?
             .deletingPrefix("b/") ?? ""
 
-        let change: FileDiff.ParsedHeader.ChangeType = if lines.contains(where: { $0.hasPrefix("deleted file mode ") }) {
-            .deleted
+        let change: FileDiff.ParsedHeader.ChangeType
+
+        if lines.contains(where: { $0.hasPrefix("deleted file mode ") }) {
+            change = .deleted
         } else if lines.contains(where: { $0.hasPrefix("new file mode") }) {
-            .created
+            change = .created
         } else if let modifiedLineIndex = lines.firstIndex(where: { $0.hasPrefix("rename from ") }) {
-            .renamed(oldPath: lines[modifiedLineIndex].deletingPrefix("rename from "))
+            change = .renamed(oldPath: lines[modifiedLineIndex].deletingPrefix("rename from "))
         } else {
-            .modified
+            change = .modified
         }
 
         return FileDiff.ParsedHeader(filePath: filePath, change: change)

Sources/Danger/Report.swift

@@ -116,14 +116,16 @@ public extension DangerDSL {
 
     /// Adds an inline suggestion to the Danger report (sends a normal message if suggestions are not supported)
     func suggestion(code: String, file: String, line: Int) {
-        let message: String = if dangerRunner.dsl.supportsSuggestions {
-            """
+        let message: String
+
+        if dangerRunner.dsl.supportsSuggestions {
+            message = """
             ```suggestion
             \(code)
             ```
             """
         } else {
-            code
+            message = code
         }
 
         globalResults.markdowns.append(Violation(message: message, file: file, line: line))

Sources/DangerDependenciesResolver/PackageManager.swift

@@ -67,10 +67,12 @@ public struct PackageManager {
     func addPackage(_ package: InlineDependenciesFinder.InlineDependency) throws {
         let name = try packageDataProvider.nameOfPackage(at: package.url, temporaryFolder: temporaryFolder)
 
-        let latestVersion: Int = if let major = package.major {
-            major
+        let latestVersion: Int
+
+        if let major = package.major {
+            latestVersion = major
         } else {
-            try packageDataProvider.latestMajorVersionForPackage(at: package.url)
+            latestVersion = try packageDataProvider.latestMajorVersionForPackage(at: package.url)
         }
         let package = Package(name: name,
                               url: absoluteRepositoryURL(from: package.url),

Sources/DangerShellExecutor/ShellExecutor.swift

@@ -115,10 +115,12 @@ public struct ShellExecutor: ShellExecuting {
                           environmentVariables: [String: String],
                           outputFile: String?) -> Process
     {
-        let scriptOutputFile = if let outputFile {
-            " > \(outputFile)"
+        let scriptOutputFile: String
+
+        if let outputFile {
+            scriptOutputFile = " > \(outputFile)"
         } else {
-            ""
+            scriptOutputFile = ""
         }
 
         let script = "\(command) \(arguments.joined(separator: " "))" + scriptOutputFile

Sources/Runner/Commands/Edit.swift

@@ -5,16 +5,18 @@ import RunnerLib
 
 func editDanger(version dangerSwiftVersion: String, logger: Logger) throws {
     let fileManager = FileManager.default
-    let dangerfilePath: String = if let dangerfileArgumentPath = DangerfilePathFinder.dangerfilePath() {
-        dangerfileArgumentPath.fullPath
+    let dangerfilePath: String
+
+    if let dangerfileArgumentPath = DangerfilePathFinder.dangerfilePath() {
+        dangerfilePath = dangerfileArgumentPath.fullPath
     } else {
-        (Runtime.getDangerfile() ?? "Dangerfile.swift").fullPath
+        dangerfilePath = (Runtime.getDangerfile() ?? "Dangerfile.swift").fullPath
     }
 
     if !fileManager.fileExists(atPath: dangerfilePath) {
         createDangerfile(dangerfilePath)
     }
-
+    
     let absoluteLibPath: String
     let libsImport: [String]
 

Sources/Runner/MarathonScriptManager.swift

@@ -5,10 +5,12 @@ import Logger
 func getScriptManager(forDangerSwiftVersion dangerSwiftVersion: String,
                       logger: Logger) throws -> ScriptManager
 {
-    let homeFolder: String = if #available(OSX 10.12, *) {
-        FileManager.default.homeDirectoryForCurrentUser.path
+    let homeFolder: String
+
+    if #available(OSX 10.12, *) {
+        homeFolder = FileManager.default.homeDirectoryForCurrentUser.path
     } else {
-        NSHomeDirectory()
+        homeFolder = NSHomeDirectory()
     }
 
     let folder = "\(homeFolder)/.danger-swift/"