Merge pull request #624 from 417-72KI/review-before-submmitted

Fix: `GitHub.Review.submittedAt` may be `nil`
danger · Oct 14, 2024 · c8d2aeb · c8d2aeb
2 parents b22f43c + 3261c11
commit c8d2aeb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,9 +13,11 @@
 
 ## Master
 
+- Fix: `GitHub.Review.submittedAt` may be `nil` [@417-72KI][] - [#624](https://github.com/danger/swift/pull/624)
 - Drain stdout while shell commands are running to prevent execution from locking up if there's too much output [@jflan-dd][] - [#614](https://github.com/danger/swift/pull/614)
 
 ## 3.20.0
+
 - Remove deprecated `lint` function with `lintAllFiles` flag [@417-72KI][] - [#622](https://github.com/danger/swift/pull/622)
 - Updated Swift 6 build process: Danger files moved to .build/debug/Modules, and SwiftFormat module map conflict resolved by adjusting the Swift import search path. [@abhi-m-simformsolutons][] -[#626](https://github.com/danger/swift/pull/626)
 

diff --git a/Sources/Danger/GitHubDSL.swift b/Sources/Danger/GitHubDSL.swift
@@ -323,8 +323,8 @@ public extension GitHub {
         /// The state of the review (if a review was made).
         public let state: State?
 
-        /// The date when the review was submitted
-        public let submittedAt: Date
+        /// The date when the review was submitted (if a review was made).
+        public let submittedAt: Date?
 
         /// The user who has completed the review or has been requested to review.
         public let user: User