Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated properties and functions in Process #634

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

417-72KI
Copy link
Member

In linux (Docker image), building Danger-Swift has some warnings.

Building for debugging...
/work/Sources/Runner/Commands/Edit.swift:20:9: warning: immutable value 'absoluteLibPath' was never used; consider removing it
    let absoluteLibPath: String
        ^
/work/Sources/Runner/Commands/Edit.swift:21:9: warning: immutable value 'libsImport' was never used; consider removing it
    let libsImport: [String]
        ^
/work/Sources/Runner/Commands/Runner.swift:155:10: warning: 'launchPath' is deprecated: renamed to 'executableURL'
    proc.launchPath = swiftC
         ^
/work/Sources/Runner/Commands/Runner.swift:155:10: note: use 'executableURL' instead
    proc.launchPath = swiftC
         ^~~~~~~~~~
         executableURL
/work/Sources/Runner/Commands/Runner.swift:162:14: warning: 'currentDirectoryPath' is deprecated: renamed to 'currentDirectoryURL'
        proc.currentDirectoryPath = directoryURL.absoluteString
             ^
/work/Sources/Runner/Commands/Runner.swift:162:14: note: use 'currentDirectoryURL' instead
        proc.currentDirectoryPath = directoryURL.absoluteString
             ^~~~~~~~~~~~~~~~~~~~
             currentDirectoryURL
/work/Sources/Runner/Commands/Runner.swift:167:10: warning: 'launch()' is deprecated: renamed to 'run'
    proc.launch()
         ^
/work/Sources/Runner/Commands/Runner.swift:167:10: note: use 'run' instead
    proc.launch()
         ^~~~~~
         run
/work/Sources/Runner/Commands/RunDangerJS.swift:25:10: warning: 'launchPath' is deprecated: renamed to 'executableURL'
    proc.launchPath = dangerJS
         ^
/work/Sources/Runner/Commands/RunDangerJS.swift:25:10: note: use 'executableURL' instead
    proc.launchPath = dangerJS
         ^~~~~~~~~~
         executableURL

This PR fixes ones that saids '~' is deprecated.

Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you :)

@417-72KI 417-72KI merged commit b41494a into danger:master Dec 24, 2024
14 checks passed
@417-72KI 417-72KI deleted the fix-deprecated branch December 24, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants