Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Actor sample #758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RicardoNiepel
Copy link

Description

  • using die ActorClient also as Dapr application
  • adding sample.http to Actor sample

Issue reference

No - only small changes

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@RicardoNiepel RicardoNiepel requested a review from a team as a code owner October 1, 2021 11:58
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #758 (d085ace) into master (1acd372) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #758   +/-   ##
=======================================
  Coverage   68.90%   68.90%           
=======================================
  Files         137      137           
  Lines        4458     4458           
  Branches      500      500           
=======================================
  Hits         3072     3072           
  Misses       1271     1271           
  Partials      115      115           
Flag Coverage Δ
net5 67.94% <ø> (-0.86%) ⬇️
netcoreapp3.1 68.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1acd372...d085ace. Read the comment docs.

On Windows: set DAPR_HTTP_PORT=<port>
On Linux, MacOS: export DAPR_HTTP_PORT=<port>
```
dapr run --app-id actor_client dotnet run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for doing this? You don't need to run this app with a dapr sidecar to invoke the actors. I think showing that you can interact with actors from outside of dapr is an important point.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then both options should be added to the docs to explain the two ways.

In real scenarios, even if you are communicating with actors from the outside - this "outside" application will not run in the actors cluster - thus expecting dapr sidecar of the actors app is running on the same machine will not be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants