Provide custom grpc/http client for DaprClientBuilder as in #683 #690

subash89 · 2022-02-23T11:59:02Z

Signed-off-by: Subash Gamage [email protected]

Description

This is to Enhance DaprClientBuilder to override gRPC and Http Client. Complete description and reference JIRA can be found at #683

This includes changes in DaprClientBuilder class to accept a managed grpc client as well as ok http client.

Issue reference

#683

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

artursouza · 2022-02-23T20:16:16Z

README.md

+
+    ```java 
+       DaprClientBuilder daprClientBuilder = new DaprClientBuilder();
+       DaprClient client = daprClientBuilder.withOkHttpClient(new OkHttpClient.Builder().readTimeout(5, TimeUnit.SECONDS)).build();


We actually plan to remove the dependency on OkHTTP. Adding that to our public methods will make that harder. Why can't a custom gRPC or HTTP client be implemented with the existing interfaces?

The DaprClientBuilder create the channel internally and not allowing a way to override that outside.

artursouza · 2022-02-23T20:17:11Z

README.md

+
+    ```java
+        DaprClientBuilder daprClientBuilder = new DaprClientBuilder();
+        ManagedChannelBuilder managedChannelBuilder = Grpc.newChannelBuilder("localhost:8000", TlsChannelCredentials.create())


This is interesting. Which are the most common settings for a managed channel? Can this be done via additional java properties?

Channel has everything that matters and as I know we cannot control them via out of the box sys properties. Example using my own managed executor service

subash89 · 2022-03-05T14:13:07Z

@artursouza I updated the PR with new changes and reverted the old commit. New change is minimal as I provided a easy way to extend the builder class. Because maintaining a two Builder classes is hard to maintain as code is duplicated.
Let me know your thoughts. And I did not touch http builder yet as you said okhttp will go away. Once we have that finalized, I will add capability to override http client as well.

mukundansundar

@subash89 Please sign off your commits following : https://github.com/dapr/java-sdk/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-signing-your-work

subash89 · 2022-03-07T07:41:06Z

Looks like it didn't like my reverse commit. I followed
git checkout
git commit --amend --no-edit --signoff
git push --force-with-lease
@mukundansundar Is it looks good now ? (How to make sure DCO is all set on a given pull request ?)

mukundansundar · 2022-03-07T09:53:32Z

@subash89 Can you rebase all your commits into a single commit ? Also could you fix the check style violations in the PR?

subash89 · 2022-03-08T21:35:28Z

@mukundansundar
If you mean to say squash commits, I cannot squash them into one as I already pushed them to the branch. If not can you suggest how can I do that ? Or I can do a new PR with only this change.

This is my first PR, where to find checkstyle report inorder to fix those.

artursouza · 2022-03-16T23:59:00Z

README.md

+    ```java
+
+    DaprExtensibleClientBuilder daprClientBuilder = new DaprExtensibleClientBuilder();
+    ManagedChannelBuilder managedChannelBuilder = Grpc.newChannelBuilder("localhost:8000", TlsChannelCredentials.create())


Please, use properties like Properties.SIDECAR_IP.get() to make this portable when users run using a different host or port in standalone mode.

artursouza · 2022-03-17T00:00:48Z

sdk/src/main/java/io/dapr/client/DaprExtensibleClientBuilder.java

+/**
+ * A builder for the DaprClient.
+ */
+public class DaprExtensibleClientBuilder extends DaprClientBuilder{


I would make this a GRPC specific builder and force the GRPC protocol, even if property is for HTTP.

With the current design, it would be possible for the code to set the GRPC managed channel and a Java property force the client built to be the HTTP instance.

Make sense.

subash89 · 2022-03-17T17:11:23Z

@artursouza meantime I update the PR, can you pls suggest a way to build this on a mac or some easy way to find out what are the checkstyle violaitons are.

subash89 · 2022-03-17T20:32:51Z

@artursouza Updated the PR. please let me know.

* Adding javadocs to some Domain classes Signed-off-by: pravinpushkar <[email protected]> * Fixing code coverage Signed-off-by: pravinpushkar <[email protected]> * Incorporating review comments Signed-off-by: pravinpushkar <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

Signed-off-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

…Subash Gamage <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

…off-by: Subash Gamage <[email protected]>" This reverts commit 1d88c76. Signed-off-by: Subash Gamage <[email protected]>

…d-off-by: Subash Gamage <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.5.0 to 3. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v2.5.0...v3) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Subash Gamage <[email protected]>

Bumps [actions/github-script](https://github.com/actions/github-script) from 5 to 6. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v5...v6) --- updated-dependencies: - dependency-name: actions/github-script dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Subash Gamage <[email protected]>

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Subash Gamage <[email protected]>

Signed-off-by: Subash Gamage <[email protected]>

* Add workflow and badge Signed-off-by: Shubham Sharma <[email protected]> * Encode space in URL Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

* Add workflow and badge Signed-off-by: Shubham Sharma <[email protected]> * Encode space in URL Signed-off-by: Shubham Sharma <[email protected]> * Update FOSSA workflow condition Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

* remove deprecated classes Signed-off-by: Mukundan Sundararajan <[email protected]> * remove builder class ref in ITs Signed-off-by: Mukundan Sundararajan <[email protected]> * fix setter in IT Signed-off-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

Signed-off-by: pravinpushkar <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

subash89 · 2022-03-23T15:19:24Z

@artursouza any help appreciated.

mukundansundar · 2022-03-23T18:08:16Z

@artursouza any help appreciated.

@subash89 Can you merge with latest master resolve conflicts and see if you are able to build it with the changes in master?

subash89 · 2022-03-23T19:15:12Z

@mukundansundar main problem I am having is to build this in a mac?
[ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project dapr-sdk-autogen: Error extracting protoc for version 3.13.0: Unsupported platform: protoc-3.13.0-osx-x86_64.exe -> [Help 1]

mukundansundar · 2022-03-24T01:58:53Z

@mukundansundar main problem I am having is to build this in a mac?
[ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project dapr-sdk-autogen: Error extracting protoc for version 3.13.0: Unsupported platform: protoc-3.13.0-osx-x86_64.exe -> [Help 1]

Does this happen with the latest changes from master too?
Because I faced a similar issue with M1 Mac and I had to update some of the dependencies and use Rosetta enabled terminal for it to work.

subash89 · 2022-03-24T19:50:33Z

Yes in master too

subash89 · 2022-04-11T13:56:11Z

Can this be build on a linux box ?

mukundansundar · 2022-04-18T22:30:41Z

Can this be build on a linux box ?

the build workflow is on a linux runner only

amuthapriya4 · 2023-06-06T16:06:52Z

Please commit the changes for Managed channel to the release branch. With current version it going with default config.

cicoyle · 2023-12-21T15:09:47Z

@subash89 - mind resolving the conflicts?

cicoyle · 2024-02-19T21:46:38Z

gentle ping @subash89

subash89 requested review from a team as code owners February 23, 2022 11:59

artursouza requested changes Feb 23, 2022

View reviewed changes

mukundansundar reviewed Mar 6, 2022

View reviewed changes

subash89 force-pushed the feature/extend-dapr-client branch from caffa08 to b7e364c Compare March 7, 2022 07:36

artursouza requested changes Mar 17, 2022

View reviewed changes

subash89 force-pushed the feature/extend-dapr-client branch from fe6c9d7 to 5d985b4 Compare March 18, 2022 14:31

pravinpushkar and others added 13 commits March 18, 2022 10:31

fix github action for dapr comment analyzer bot (dapr#680)

75d3bdd

Signed-off-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

Provide custom grpc/http client for DaprClientBuilder Signed-off-by: …

2e9af80

…Subash Gamage <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

Revert "Provide custom grpc/http client for DaprClientBuilder Signed-…

888c1e7

…off-by: Subash Gamage <[email protected]>" This reverts commit 1d88c76. Signed-off-by: Subash Gamage <[email protected]>

Provide custom grpc/http client for DaprClientBuilder update 2. Signe…

4b64452

…d-off-by: Subash Gamage <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

Making GrpcDaprClient builder restricted to only grpc

3226c1c

Signed-off-by: Subash Gamage <[email protected]>

Add FOSSA workflow and badge (dapr#703)

63b38b6

* Add workflow and badge Signed-off-by: Shubham Sharma <[email protected]> * Encode space in URL Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

Adding link for MSFT JDK11 in README.md (dapr#707)

5d985b4

Signed-off-by: pravinpushkar <[email protected]> Signed-off-by: Subash Gamage <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide custom grpc/http client for DaprClientBuilder as in #683 #690

Provide custom grpc/http client for DaprClientBuilder as in #683 #690

subash89 commented Feb 23, 2022

artursouza Feb 23, 2022

subash89 Mar 5, 2022

artursouza Feb 23, 2022

subash89 Mar 5, 2022

subash89 commented Mar 5, 2022

mukundansundar left a comment

subash89 commented Mar 7, 2022

mukundansundar commented Mar 7, 2022

subash89 commented Mar 8, 2022

artursouza Mar 16, 2022

artursouza Mar 17, 2022

subash89 Mar 17, 2022

subash89 commented Mar 17, 2022

subash89 commented Mar 17, 2022

subash89 commented Mar 23, 2022

mukundansundar commented Mar 23, 2022

subash89 commented Mar 23, 2022

mukundansundar commented Mar 24, 2022 •

edited

Loading

subash89 commented Mar 24, 2022

subash89 commented Apr 11, 2022

mukundansundar commented Apr 18, 2022

amuthapriya4 commented Jun 6, 2023

cicoyle commented Dec 21, 2023

cicoyle commented Feb 19, 2024

Provide custom grpc/http client for DaprClientBuilder as in #683 #690

Are you sure you want to change the base?

Provide custom grpc/http client for DaprClientBuilder as in #683 #690

Conversation

subash89 commented Feb 23, 2022

Description

Issue reference

Checklist

artursouza Feb 23, 2022

Choose a reason for hiding this comment

subash89 Mar 5, 2022

Choose a reason for hiding this comment

artursouza Feb 23, 2022

Choose a reason for hiding this comment

subash89 Mar 5, 2022

Choose a reason for hiding this comment

subash89 commented Mar 5, 2022

mukundansundar left a comment

Choose a reason for hiding this comment

subash89 commented Mar 7, 2022

mukundansundar commented Mar 7, 2022

subash89 commented Mar 8, 2022

artursouza Mar 16, 2022

Choose a reason for hiding this comment

artursouza Mar 17, 2022

Choose a reason for hiding this comment

subash89 Mar 17, 2022

Choose a reason for hiding this comment

subash89 commented Mar 17, 2022

subash89 commented Mar 17, 2022

subash89 commented Mar 23, 2022

mukundansundar commented Mar 23, 2022

subash89 commented Mar 23, 2022

mukundansundar commented Mar 24, 2022 • edited Loading

subash89 commented Mar 24, 2022

subash89 commented Apr 11, 2022

mukundansundar commented Apr 18, 2022

amuthapriya4 commented Jun 6, 2023

cicoyle commented Dec 21, 2023

cicoyle commented Feb 19, 2024

mukundansundar commented Mar 24, 2022 •

edited

Loading