Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support invokeXXX return Response #755

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

naah69
Copy link

@naah69 naah69 commented Jun 27, 2022

Description

add DaprResponse interface and HttpDaprResponse,GrpcDaprRespnse implement.

Issue reference

#751

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@naah69 naah69 requested review from a team as code owners June 27, 2022 06:43
@tanvigour
Copy link
Contributor

Please resolve the conflicts

@naah69
Copy link
Author

naah69 commented Jun 29, 2022

Please resolve the conflicts

it had resolved.

artursouza and others added 17 commits July 7, 2022 13:57
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: naah69 <[email protected]>
* run IT test for long values

Signed-off-by: tanvigour <[email protected]>

* Fix the class name

Signed-off-by: tanvigour <[email protected]>

* assert for all messages and fix class name

Signed-off-by: tanvigour <[email protected]>

* test for Long.MAX_VALUE

Signed-off-by: tanvigour <[email protected]>

* revert back long number and print

Signed-off-by: tanvigour <[email protected]>

* fix the typo

Signed-off-by: tanvigour <[email protected]>

* update the latest dapr commit in workflow files

Signed-off-by: tanvigour <[email protected]>

* log some more data to debug

Signed-off-by: tanvigour <[email protected]>

* debug

Signed-off-by: tanvigour <[email protected]>

* get the value from messages

Signed-off-by: tanvigour <[email protected]>

* fix long values assert

Signed-off-by: Mukundan Sundararajan <[email protected]>

* increasing TTL

Signed-off-by: Mukundan Sundararajan <[email protected]>

Co-authored-by: tanvigour <[email protected]>
Co-authored-by: tanvigour <[email protected]>
Signed-off-by: naah69 <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: naah69 <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: naah69 <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: naah69 <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: naah69 <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: naah69 <[email protected]>
* replace vault to local

Signed-off-by: zjx244729 <[email protected]>

* change secret store name style

Signed-off-by: zjx244729 <[email protected]>

* delete vault token file

Signed-off-by: zjx244729 <[email protected]>

* remove vault int validate.yml

Signed-off-by: zjx244729 <[email protected]>

* fix it secret case

Signed-off-by: zjx244729 <[email protected]>

* replace vault to local

Signed-off-by: zjx244729 <[email protected]>

* change secret store name style

Signed-off-by: zjx244729 <[email protected]>

* delete vault token file

Signed-off-by: zjx244729 <[email protected]>

* remove vault int validate.yml

Signed-off-by: zjx244729 <[email protected]>

* fix it secret case

Signed-off-by: zjx244729 <[email protected]>

* fix it dead loop

Signed-off-by: zjx244729 <[email protected]>

Co-authored-by: zjx244729 <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: naah69 <[email protected]>
Bumps [fossas/fossa-action](https://github.com/fossas/fossa-action) from 1.1.0 to 1.3.1.
- [Release notes](https://github.com/fossas/fossa-action/releases)
- [Commits](fossas/fossa-action@v1.1.0...v1.3.1)

---
updated-dependencies:
- dependency-name: fossas/fossa-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: naah69 <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.1.0 to 3.1.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v2.1.0...v3.1.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: naah69 <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: naah69 <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: naah69 <[email protected]>
* Adding pubsub routing support

Signed-off-by: Artur Souza <[email protected]>

* remove deprecated classes (dapr#704)

* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Artur Souza <[email protected]>

* Address PR comments.

Signed-off-by: Artur Souza <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Signed-off-by: naah69 <[email protected]>
Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not support invoke via gRPC anymore. Only HTTP. Please, change this PR to make the invoke method to be over HTTP only - you can use the PreviewClient interface for that.

@naah69
Copy link
Author

naah69 commented Jul 10, 2022

change

ok i will change it .

@mukundansundar
Copy link
Contributor

@skyao Can you review this PR?

naah69 added 2 commits July 21, 2022 19:48
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: naah69 <[email protected]>

# Conflicts:
#	examples/pom.xml
#	pom.xml
#	sdk-actors/pom.xml
#	sdk-autogen/pom.xml
#	sdk-springboot/pom.xml
#	sdk-tests/pom.xml
#	sdk/pom.xml
Copy link
Author

@naah69 naah69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it had changed.
@artursouza

@naah69 naah69 requested a review from artursouza July 22, 2022 02:52
Copy link
Author

@naah69 naah69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it changed

Copy link
Author

@naah69 naah69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewed

@naah69
Copy link
Author

naah69 commented Aug 8, 2022

any progress?

@mukundansundar
Copy link
Contributor

@naah69 Can you please fix the conflicts in the PR?

@cicoyle
Copy link
Contributor

cicoyle commented Feb 19, 2024

gentle ping @naah69

1 similar comment
@cicoyle
Copy link
Contributor

cicoyle commented Jun 19, 2024

gentle ping @naah69

@imerljak
Copy link

Is this still alive? Would be really nice to have it in order to get proper response status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants