Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cross-ref to rgblevels for 'brightness' (gamma) adjustment in c-b-s #644

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ralfbrown
Copy link
Contributor

No description provided.

@elstoc
Copy link
Contributor

elstoc commented Apr 9, 2024

I'm not sure whether we want to suggest using rgb levels or curves do we? While they're both "rgb" IIRC the controls/interfaces are still display-referred and I think we'd prefer to direct people to scene-referred modules where possible.

@ralfbrown
Copy link
Contributor Author

True enough, but RGB levels is simpler to use for the cases where the data is within 0...1 (or even a little beyond, since it extrapolates the gamma curve). To properly handle values well above 1, you need to adjust the white and/or gray fulcrum values in colorbalance RGB. Plus levels gives you a picker to set the gamma from a midtone pixel, which colorbalance doesn't.

@elstoc
Copy link
Contributor

elstoc commented Apr 20, 2024

Perhaps a rewording then to make it clear that color balance rgb is recommended but that rgb levels provides similar controls to those in the deprecated module.

Copy link

This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No activity on this PR label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity No activity on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants