-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rendering-intent.md #664
base: master
Are you sure you want to change the base?
Conversation
Added short explanation of what a rendering intent is.
@@ -5,6 +5,7 @@ weight: 40 | |||
draft: false | |||
author: "people" | |||
--- | |||
A rendering intent is a method of converting colours from one ICC profile to another.They handle issues when converting from one profile to another, as there may be colours that are in gamut of the source profile but out of gamut of the destination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a space after the first period.
I am not sure we should be explaining rendering intent to people... it isn't really the place of the manual to explain general concepts to the user. |
The page already defines what the rendering intent is, and it's nothing to do with ICC profiles: "define how to handle out-of-gamut colors when converting between color spaces" |
Added spacing after first sentence
When I first started using dt, I had no idea about rendering intents, but I could see that a choice had to be made even when exporting an image to jpg. My feeling is that users in that situation should be able to go to the "rendering intent" page of the dt manual and see a short definition of rendering intent. Chris - the existing text really does not give a definition, and looking at half a dozen web pages that do give a definition, they all link rendering closely with ICC profiles. I don't claim to be a colour management expert, but the text I proposed seems to be in line with most explanations I can find. |
I would rather wording like this be confirmed by someone who does know what it means because It doesn't look right to me. I'm sure the term rendering intent can be used in the context of ICC profiles, but I'm also pretty sure that's not the intended context here. |
This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work. |
Added short explanation of what a rendering intent is.