Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich pixels #61

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Rich pixels #61

wants to merge 8 commits into from

Conversation

murilo-cunha
Copy link
Member

Add rich-pixels as an optional dependency for rendering pixelated images in the terminal with rich

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #61 (747475c) into main (d6884d2) will decrease coverage by 0.36%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   95.42%   95.07%   -0.36%     
==========================================
  Files          28       28              
  Lines        1531     1544      +13     
==========================================
+ Hits         1461     1468       +7     
- Misses         70       76       +6     
Files Changed Coverage
databooks/data_models/cell.py 50.00%
databooks/data_models/_rich.py 58.33%
tests/test_data_models/test_rich_helpers.py 100.00%

Copy link
Contributor

@astronautas astronautas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are conflicts due to this PR being super old 😢 (I don't have the write access to help).

@astronautas
Copy link
Contributor

astronautas commented Sep 19, 2023

@murilo-cunha If you'd give me "write access", I could approve ;].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants