fix: consider the original config for signs #4872
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It always overwrites signs' config this code below, and therefore, all user settings are ignored.
ale/lua/ale/diagnostics.lua
Line 68 in 65b49c1
With this patch, ALE considers user settings and overwrites
priority
only if needed.The feature for retrieving the current config values for diagnostics has been implemented in neovim/neovim#17045. This patch is included in Neovim v0.7.0 and higher, so this fix cannot work with v0.6.x -- the minimum version ALE supports. For v0.6.x, I did a small fix (1485bab).