Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider the original config for signs #4872

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

delphinus
Copy link
Contributor

@delphinus delphinus commented Nov 28, 2024

It always overwrites signs' config this code below, and therefore, all user settings are ignored.

signs = {priority = vim.g.ale_sign_priority }

With this patch, ALE considers user settings and overwrites priority only if needed.


The feature for retrieving the current config values for diagnostics has been implemented in neovim/neovim#17045. This patch is included in Neovim v0.7.0 and higher, so this fix cannot work with v0.6.x -- the minimum version ALE supports. For v0.6.x, I did a small fix (1485bab).

@delphinus delphinus force-pushed the fix/consider-original-sign-config branch 2 times, most recently from 25b164c to a17b062 Compare November 28, 2024 11:01
@delphinus
Copy link
Contributor Author

@w0rp The current minimum version to support is Neovim 0.6.0. I found this was determined in #4345 because 0.6.0 is the first version that implemented vim.diagnostic.

Can you bump up this to 0.7.0 or higher? I want to fix this problem in this PR, but it needs the feature in 0.7.0 (details are written in PR's description).

@delphinus delphinus force-pushed the fix/consider-original-sign-config branch from 1485bab to 9b9c743 Compare December 3, 2024 03:54
@hsanson
Copy link
Contributor

hsanson commented Dec 29, 2024

@delphinus will try to tackle this during holidays: #4887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants