Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add sponsor Django banner to Trac #143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sarahboyce
Copy link
Contributor

Desktop:
image

Mobile:
Screenshot from 2023-08-11 22-59-49

@tim-schilling
Copy link
Member

@sarahboyce have you considered putting this text below the block of "Please read this first"? We definitely want to make it easier to find our donate button(s), but I suspect we still want the focus of this page to be on how to create a ticket for Django. Pushing that down is counter productive to the main purpose of the page.

Would it be possible to render this on the initial render of the issue after it's been created too?

@sarahboyce
Copy link
Contributor Author

Updated images based off new shortened wording:
short-desktop
short-mobile

have you considered putting this text below the block of "Please read this first"?

@tim-schilling the banner would be on all the Trac pages (not just the new ticket page) and the "Please read this first" I think is still promeninent as it's before you can submit 🤔 Now the wording is shorter do you still feel the same? If we're worried I can hide the banner on the New ticket page and only show it on the detail and list pages?

@sarahboyce sarahboyce marked this pull request as ready for review August 23, 2023 17:42
@tim-schilling
Copy link
Member

Now the wording is shorter do you still feel the same? If we're worried I can hide the banner on the New ticket page and only show it on the detail and list pages?

@sarahboyce with the shorter wording it's not a concern. Thank you for taking it into consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants