Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always accept .o and .obj files extensions from CLI for all platforms #20609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denizzzka
Copy link
Contributor

@denizzzka denizzzka commented Dec 27, 2024

Proposal to discuss
Explanation: ldc-developers/ldc#4733

This patch makes DMD behave the same as clang and maybe all other modern compilers. Seems, there is no point in discarding *.o or *.obj depending on current OS - both extensions point us that this is object file

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20609"

@rikkimax
Copy link
Contributor

Don't forget to make this change in dub as well, it does filtering.

@denizzzka
Copy link
Contributor Author

@rikkimax It seems like no changes are needed to DUB: this PR only affects reading of external object files provided by 3rd party build systems (like CMake). If current DUb does things correct it will not need to fix anything

@denizzzka denizzzka changed the title Always accept .o and .obj files for all platforms Always accept .o and .obj files extensions from CLI for all platforms Dec 27, 2024
@denizzzka denizzzka marked this pull request as ready for review December 27, 2024 07:14
Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea looks okay to me, I just have a comment about the code quality.

compiler/src/dmd/mars.d Outdated Show resolved Hide resolved
compiler/src/dmd/target.d Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants